From: Pierre Morel <pmorel@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, cohuck@redhat.com, thuth@redhat.com,
hca@linux.ibm.com, gor@linux.ibm.com, svens@linux.ibm.com
Subject: Re: [PATCH v2 1/1] KVM: s390: vsie: clarifications on setting the APCB
Date: Wed, 26 Oct 2022 10:18:06 +0200 [thread overview]
Message-ID: <d29c3e4d-89cb-88dc-6809-5b52c8a2525e@linux.ibm.com> (raw)
In-Reply-To: <20221025182039.6dc82fbf@p-imbrenda>
On 10/25/22 18:20, Claudio Imbrenda wrote:
> On Tue, 25 Oct 2022 15:17:36 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> On 10/25/22 11:30, David Hildenbrand wrote:
>>> On 25.10.22 11:13, Pierre Morel wrote:
>>>> The APCB is part of the CRYCB.
>>>> The calculation of the APCB origin can be done by adding
>>>> the APCB offset to the CRYCB origin.
>>>>
>>>> Current code makes confusing transformations, converting
>>>> the CRYCB origin to a pointer to calculate the APCB origin.
>>>>
>>>
>>>
>>> While at it, can we rename "crycb_o" to "crycb_gpa" and "apcb_o" to
>>> "apcb_gpa".
>>>
>>> These are not pointers but guest physical addresses.
>>>
>>
>> I can do that.
>> the _o came from the name in the documentation "origin"
>> but gpa is more obvious.
>>
>
> with that fixed:
>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
prev parent reply other threads:[~2022-10-26 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 9:13 [PATCH v2 0/1] KVM: s390: vsie: clarifications on setting the APCB Pierre Morel
2022-10-25 9:13 ` [PATCH v2 1/1] " Pierre Morel
2022-10-25 9:30 ` David Hildenbrand
2022-10-25 13:17 ` Pierre Morel
2022-10-25 16:20 ` Claudio Imbrenda
2022-10-26 8:18 ` Pierre Morel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29c3e4d-89cb-88dc-6809-5b52c8a2525e@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).