From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E890C3524B for ; Tue, 4 Feb 2020 04:07:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24B3620732 for ; Tue, 4 Feb 2020 04:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SS/40Myd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbgBDEHe (ORCPT ); Mon, 3 Feb 2020 23:07:34 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:43778 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727015AbgBDEHe (ORCPT ); Mon, 3 Feb 2020 23:07:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580789253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7B85Tuhdr78AsiT4Ni5YNT6BLFTLG2y3kO7hKIaH4E=; b=SS/40Myde0LXqmAP6XcapMGnvwxWHcVE3JTAKxBwd0SfmLaEZfYDeQISVR1xdMy3QM33X0 tae1wuHCHFViH4GfIFKQGHrFCAe7dtEK5LLoKgQHRa/iaMeJMdCLUrtPYHyBRjhZ49Z26m NbdEVKWIkllPRkDZja3W6QQ+n1SXsbs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-IG-2EzjCNL6GTf6APFeeAw-1; Mon, 03 Feb 2020 23:07:23 -0500 X-MC-Unique: IG-2EzjCNL6GTf6APFeeAw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3AD66800D55; Tue, 4 Feb 2020 04:07:20 +0000 (UTC) Received: from [10.72.12.170] (ovpn-12-170.pek2.redhat.com [10.72.12.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7A691001920; Tue, 4 Feb 2020 04:07:02 +0000 (UTC) Subject: Re: [PATCH 5/5] vdpasim: vDPA device simulator To: Dan Carpenter , kbuild@lists.01.org Cc: kbuild-all@lists.01.org, mst@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, tiwei.bie@intel.com, jgg@mellanox.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, lingshan.zhu@intel.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, kevin.tian@intel.com, stefanha@redhat.com, rdunlap@infradead.org, hch@infradead.org, aadam@redhat.com, jakub.kicinski@netronome.com, jiri@mellanox.com, shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com References: <20200128033215.GO1870@kadam> From: Jason Wang Message-ID: Date: Tue, 4 Feb 2020 12:07:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200128033215.GO1870@kadam> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/1/28 =E4=B8=8A=E5=8D=8811:32, Dan Carpenter wrote: > Hi Jason, > > url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-suppor= t/20200117-170243 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git l= inux-next Will fix this. Thanks > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/virtio/vdpa/vdpa_sim.c:288 vdpasim_alloc_coherent() warn: retur= ning freed memory 'addr' > > # https://github.com/0day-ci/linux/commit/55047769b3e974d68b2aab5ce0022= 459b172a23f > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout 55047769b3e974d68b2aab5ce0022459b172a23f > vim +/addr +288 drivers/virtio/vdpa/vdpa_sim.c > > 55047769b3e974 Jason Wang 2020-01-16 263 static void *vdpasim_alloc_c= oherent(struct device *dev, size_t size, > 55047769b3e974 Jason Wang 2020-01-16 264 dma_addr_t *dma_addr= , gfp_t flag, > 55047769b3e974 Jason Wang 2020-01-16 265 unsigned long attrs) > 55047769b3e974 Jason Wang 2020-01-16 266 { > 55047769b3e974 Jason Wang 2020-01-16 267 struct vdpa_device *vdpa =3D= dev_to_vdpa(dev); > 55047769b3e974 Jason Wang 2020-01-16 268 struct vdpasim *vdpasim =3D= vdpa_to_sim(vdpa); > 55047769b3e974 Jason Wang 2020-01-16 269 struct vhost_iotlb *iommu =3D= vdpasim->iommu; > 55047769b3e974 Jason Wang 2020-01-16 270 void *addr =3D kmalloc(size= , flag); > 55047769b3e974 Jason Wang 2020-01-16 271 int ret; > 55047769b3e974 Jason Wang 2020-01-16 272 > 55047769b3e974 Jason Wang 2020-01-16 273 if (!addr) > 55047769b3e974 Jason Wang 2020-01-16 274 *dma_addr =3D DMA_MAPPING_= ERROR; > 55047769b3e974 Jason Wang 2020-01-16 275 else { > 55047769b3e974 Jason Wang 2020-01-16 276 u64 pa =3D virt_to_phys(ad= dr); > 55047769b3e974 Jason Wang 2020-01-16 277 > 55047769b3e974 Jason Wang 2020-01-16 278 ret =3D vhost_iotlb_add_ra= nge(iommu, (u64)pa, > 55047769b3e974 Jason Wang 2020-01-16 279 (u64)pa + size - 1, > 55047769b3e974 Jason Wang 2020-01-16 280 pa, VHOST_MAP_RW); > 55047769b3e974 Jason Wang 2020-01-16 281 if (ret) { > 55047769b3e974 Jason Wang 2020-01-16 282 kfree(addr); > ^^^^^^= ^^^^^ > 55047769b3e974 Jason Wang 2020-01-16 283 *dma_addr =3D DMA_MAPPING= _ERROR; > 55047769b3e974 Jason Wang 2020-01-16 284 } else > 55047769b3e974 Jason Wang 2020-01-16 285 *dma_addr =3D (dma_addr_t= )pa; > 55047769b3e974 Jason Wang 2020-01-16 286 } > 55047769b3e974 Jason Wang 2020-01-16 287 > 55047769b3e974 Jason Wang 2020-01-16 @288 return addr; > ^^^^^^^^^^^^ > 55047769b3e974 Jason Wang 2020-01-16 289 } > > --- > 0-DAY kernel test infrastructure Open Source Technology= Center > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corp= oration >