From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46064C433E0 for ; Fri, 3 Jul 2020 08:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F4B7206DF for ; Fri, 3 Jul 2020 08:39:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="a+6dn6fC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgGCIjB (ORCPT ); Fri, 3 Jul 2020 04:39:01 -0400 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:55419 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgGCIjB (ORCPT ); Fri, 3 Jul 2020 04:39:01 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud8.xs4all.net with ESMTPA id rHDjj8Fb8mVFqrHDmj7MDr; Fri, 03 Jul 2020 10:38:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1593765539; bh=t+CobNXMVOxHCVjy1njKnSsYBRTOdtR1TWHyIIr7Urs=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=a+6dn6fCPo663j3dBcDSpcsEwhtkPMiqZSeS7LAvNM4ojM5+rVGXEIQKdFrxPlpiQ i7iogRRVK9vfU8dehzfpwiV4d0bmqWCxJkUMqxDFbioTyJrj0rKcWNhuEImoEp9MP4 zFRVywAOCb1mWTc6xSDpaoxckRQSsQeLF3ffUYnDabYGPjN0ykdkMAz7nxJ3qjaLjk qxrV3qZH/g4ivjEkigNyB2WuExf48Qgl5ijQipvRN5Mk2gerkpb5FydeRb3i+oJjqv KhjFGAnDreHp6C3l78YrWvypam3oaDR+erGEYeayCTJppJkltBFC/ZmnNnQ1boDrGP Vyw2WN0OpF/vA== Subject: Re: [PATCH 4/9] media: add Mediatek's MM21 format To: Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Rui Wang , Yunfei Dong , Pi-Hsun Shih , Maoguang Meng Cc: linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200630062711.4169601-1-acourbot@chromium.org> <20200630062711.4169601-5-acourbot@chromium.org> From: Hans Verkuil Message-ID: Date: Fri, 3 Jul 2020 10:38:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200630062711.4169601-5-acourbot@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKNZeseXYKwmOKbDZ0Vyx/e5xG+FeEKX8ZLoVJw6AZXiESC6p6M3iQAJHiAlhrRlpZ7A9AymnWQO5n1OGoWPya13myHFEiQv76VX4y5ok77oux4Ci1jk exJ93H6EIRZbF5+xba+mhaUYF+ekuotphgYY9qLYkc+fhAbcCCqMNiAB5xgsAP12qAWzAKYyDWo5VlxiLV8xh09hni3r/kOfCMKWfppPxACwBlMPzT2wylUl b4LhOgT5gTlBfY1vHlH+JacqzNIHRMO4orRQI7Gc9bwZ9UG/Y5PC5hy0bYPRJKMTsfkSEjwjbrZPotVnM05dt1M2NETtH69y5aviX8NScdBRprmj/babaExj 6LWXajcaXcIEFDttV8N9U/QIxBXFcN+tz1pQ9CHpwE98uetjuxePq27AKuuCiaEqDLz0q5gMGahT+VO5eJ/FDMlxFiXvsmQ6chHrTMwPKmxNoFrtv5KAJd46 z5IUEKfbM25caYU1k6LJvsvCgWucFZAqJOh4kJAkHDyXvA8gdf5gWrpq96I= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/06/2020 08:27, Alexandre Courbot wrote: > Add Mediatek's non-compressed 8 bit block video mode. This format is > produced by the MT8183 codec and can be converted to a non-proprietary > format by the MDP3 component. > > Signed-off-by: Alexandre Courbot > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 02bfef0da76d..612be602bf76 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1398,6 +1398,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > case V4L2_META_FMT_VIVID: descr = "Vivid Metadata"; break; > + case V4L2_PIX_FMT_MM21: descr = "Mediatek 8-bit block format"; break; Can you move this up so it comes after V4L2_PIX_FMT_KONICA420? This format should also be added to Documentation/userspace-api/media/v4l/pixfmt-reserved.rst. Regards, Hans > > default: > /* Compressed formats */ > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 303805438814..a35f65115bca 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -738,6 +738,7 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I') /* Greyscale 12-bit L/R interleaved */ > #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ') /* Depth data 16-bit */ > #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */ > +#define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1') /* Mediatek 8-bit block mode, two non-contiguous planes */ > #define V4L2_PIX_FMT_INZI v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */ > #define V4L2_PIX_FMT_SUNXI_TILED_NV12 v4l2_fourcc('S', 'T', '1', '2') /* Sunxi Tiled NV12 Format */ > #define V4L2_PIX_FMT_CNF4 v4l2_fourcc('C', 'N', 'F', '4') /* Intel 4-bit packed depth confidence information */ >