From: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>
To: "Singh, Brijesh" <brijesh.singh@amd.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hook, Gary" <Gary.Hook@amd.com>
Subject: Re: [PATCH] crypto: ccp: fix the SEV probe in kexec boot path
Date: Thu, 31 Jan 2019 15:08:01 +0000 [thread overview]
Message-ID: <d2cec2a1-25ef-6fde-bca4-22a72fed8d96@amd.com> (raw)
In-Reply-To: <20190130205710.14268-1-brijesh.singh@amd.com>
On 1/30/19 2:57 PM, Singh, Brijesh wrote:
> A kexec reboot may leave the firmware in INIT or WORKING state.
> Currently, we issue PLATFORM_INIT command during the probe without
> checking the current state. The PLATFORM_INIT command fails if the
> FW is already in INIT state. Lets check the current state, if FW
> is not in UNINIT state then transition it to UNINIT before
> initializing or upgrading the FW.
>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Gary Hook <gary.hook@amd.com>
> ---
> drivers/crypto/ccp/psp-dev.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
> index b16be8a11d92..966ca6f9cf79 100644
> --- a/drivers/crypto/ccp/psp-dev.c
> +++ b/drivers/crypto/ccp/psp-dev.c
> @@ -437,6 +437,7 @@ static int sev_get_api_version(void)
> psp_master->api_major = status->api_major;
> psp_master->api_minor = status->api_minor;
> psp_master->build = status->build;
> + psp_master->sev_state = status->state;
>
> return 0;
> }
> @@ -964,6 +965,21 @@ void psp_pci_init(void)
> if (sev_get_api_version())
> goto err;
>
> + /*
> + * If platform is not in UNINIT state then firmware upgrade and/or
> + * platform INIT command will fail. These command require UNINIT state.
> + *
> + * In a normal boot we should never run into case where the firmware
> + * is not in UNINIT state on boot. But in case of kexec boot, a reboot
> + * may not go through a typical shutdown sequence and may leave the
> + * firmware in INIT or WORKING state.
> + */
> +
> + if (psp_master->sev_state != SEV_STATE_UNINIT) {
> + sev_platform_shutdown(NULL);
> + psp_master->sev_state = SEV_STATE_UNINIT;
> + }
> +
> if (SEV_VERSION_GREATER_OR_EQUAL(0, 15) &&
> sev_update_firmware(psp_master->dev) == 0)
> sev_get_api_version();
>
next prev parent reply other threads:[~2019-01-31 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 20:57 [PATCH] crypto: ccp: fix the SEV probe in kexec boot path Singh, Brijesh
2019-01-31 15:08 ` Lendacky, Thomas [this message]
2019-02-08 7:47 ` [PATCH] crypto: ccp - " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2cec2a1-25ef-6fde-bca4-22a72fed8d96@amd.com \
--to=thomas.lendacky@amd.com \
--cc=Gary.Hook@amd.com \
--cc=brijesh.singh@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).