From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>
Subject: Re: [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups
Date: Mon, 6 Apr 2020 18:06:41 +0200 [thread overview]
Message-ID: <d2d2fe98-bfc5-a43e-a8a8-a3da7f765b56@de.ibm.com> (raw)
In-Reply-To: <20200403153050.20569-1-david@redhat.com>
Series applied. thanks.
I will schedule the first 3 for master, 4 and 5 for next.
On 03.04.20 17:30, David Hildenbrand wrote:
> Some vsie/gmap fixes and two cleanups/improvements.
>
> Patch #1 fixes an issue reported by Janosch. It was never observed so far,
> because KVM usually doesn't use a region 1 table for it's guest (unless
> memory would be exceeding something like 16 EB, which isn't even supported
> by the HW). Older QEMU+KVM or other hypervisors can trigger this.
>
> Patch #2 fixes a code path that probably was never taken and will most
> probably not be taken very often in the future - unless somebody really
> messes up the page tables for a guest (or writes a test for it). At some
> point, a test case for this would be nice.
>
> Patch #3 fixes a rare possible race. Don't think this is stable material.
>
> Gave it some testing with my limited access to somewhat-fast s390x
> machines. Booted a Linux kernel, supplying all possible number of
> page table hiearchies.
>
> v1 -> v2:
> - "KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks"
> -- Fix WARN_ON_ONCE
> - "gmap_table_walk() simplifications"
> -- Also init "table" directly
>
> David Hildenbrand (5):
> KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks
> KVM: s390: vsie: Fix delivery of addressing exceptions
> KVM: s390: vsie: Fix possible race when shadowing region 3 tables
> KVM: s390: vsie: Move conditional reschedule
> KVM: s390: vsie: gmap_table_walk() simplifications
>
> arch/s390/kvm/vsie.c | 4 ++--
> arch/s390/mm/gmap.c | 17 +++++++++++------
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
prev parent reply other threads:[~2020-04-06 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 15:30 [PATCH v2 0/5] KVM: s390: vsie: fixes and cleanups David Hildenbrand
2020-04-03 15:30 ` [PATCH v2 1/5] KVM: s390: vsie: Fix region 1 ASCE sanity shadow address checks David Hildenbrand
2020-04-03 17:56 ` Christian Borntraeger
2020-04-03 19:55 ` David Hildenbrand
2020-04-06 8:32 ` Christian Borntraeger
2020-04-07 7:33 ` Christian Borntraeger
2020-04-07 7:49 ` David Hildenbrand
2020-04-07 7:52 ` Christian Borntraeger
2020-04-07 7:53 ` David Hildenbrand
2020-04-07 10:48 ` Claudio Imbrenda
2020-04-03 15:30 ` [PATCH v2 2/5] KVM: s390: vsie: Fix delivery of addressing exceptions David Hildenbrand
2020-04-07 11:00 ` Claudio Imbrenda
2020-04-07 11:35 ` David Hildenbrand
2020-04-03 15:30 ` [PATCH v2 3/5] KVM: s390: vsie: Fix possible race when shadowing region 3 tables David Hildenbrand
2020-04-07 11:05 ` Claudio Imbrenda
2020-04-03 15:30 ` [PATCH v2 4/5] KVM: s390: vsie: Move conditional reschedule David Hildenbrand
2020-04-06 15:06 ` Christian Borntraeger
2020-04-07 10:52 ` Claudio Imbrenda
2020-04-03 15:30 ` [PATCH v2 5/5] KVM: s390: vsie: gmap_table_walk() simplifications David Hildenbrand
2020-04-06 16:06 ` Christian Borntraeger
2020-04-07 11:10 ` Claudio Imbrenda
2020-04-06 16:06 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d2fe98-bfc5-a43e-a8a8-a3da7f765b56@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).