* [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
@ 2021-03-17 8:40 Bhaskar Chowdhury
2021-03-17 17:54 ` Reinette Chatre
0 siblings, 1 reply; 7+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-17 8:40 UTC (permalink / raw)
To: fenghua.yu, reinette.chatre, tglx, mingo, bp, x86, hpa, linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/derefence/dereference/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
index e916646adc69..43990a882b36 100644
--- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
+++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
@@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
* If the thread does not get on the CPU for whatever
* reason and the process which sets up the region is
* interrupted then this will leave the thread in runnable
- * state and once it gets on the CPU it will derefence
+ * state and once it gets on the CPU it will dereference
* the cleared, but not freed, plr struct resulting in an
* empty pseudo-locking loop.
*/
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 8:40 [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c Bhaskar Chowdhury
@ 2021-03-17 17:54 ` Reinette Chatre
2021-03-17 18:01 ` Randy Dunlap
2021-03-17 19:33 ` Bhaskar Chowdhury
0 siblings, 2 replies; 7+ messages in thread
From: Reinette Chatre @ 2021-03-17 17:54 UTC (permalink / raw)
To: Bhaskar Chowdhury, fenghua.yu, tglx, mingo, bp, x86, hpa, linux-kernel
Cc: rdunlap
Hi Bhaskar,
Thank you very much for catching this typo.
My feedback [1] to a previous patch from you applies here also. The
prefix should be "x86/resctrl:" for contributions to this area.
[1]
https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>
> s/derefence/dereference/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> index e916646adc69..43990a882b36 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
> * If the thread does not get on the CPU for whatever
> * reason and the process which sets up the region is
> * interrupted then this will leave the thread in runnable
> - * state and once it gets on the CPU it will derefence
> + * state and once it gets on the CPU it will dereference
> * the cleared, but not freed, plr struct resulting in an
> * empty pseudo-locking loop.
> */
> --
> 2.30.2
>
Reinette
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 17:54 ` Reinette Chatre
@ 2021-03-17 18:01 ` Randy Dunlap
2021-03-17 19:29 ` Bhaskar Chowdhury
2021-03-17 19:33 ` Bhaskar Chowdhury
1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2021-03-17 18:01 UTC (permalink / raw)
To: Reinette Chatre, Bhaskar Chowdhury, fenghua.yu, tglx, mingo, bp,
x86, hpa, linux-kernel
On 3/17/21 10:54 AM, Reinette Chatre wrote:
> Hi Bhaskar,
>
> Thank you very much for catching this typo.
>
> My feedback [1] to a previous patch from you applies here also. The prefix should be "x86/resctrl:" for contributions to this area.
Bhaskar,
Pretty much all of your patches need to have improved Subject: lines.
The file name that is being modified should not be at the end of the Subject.
>
> [1] https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
>
> On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>>
>> s/derefence/dereference/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> index e916646adc69..43990a882b36 100644
>> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
>> * If the thread does not get on the CPU for whatever
>> * reason and the process which sets up the region is
>> * interrupted then this will leave the thread in runnable
>> - * state and once it gets on the CPU it will derefence
>> + * state and once it gets on the CPU it will dereference
>> * the cleared, but not freed, plr struct resulting in an
>> * empty pseudo-locking loop.
>> */
>> --
>> 2.30.2
>>
>
> Reinette
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 18:01 ` Randy Dunlap
@ 2021-03-17 19:29 ` Bhaskar Chowdhury
0 siblings, 0 replies; 7+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-17 19:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: Reinette Chatre, fenghua.yu, tglx, mingo, bp, x86, hpa, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
On 11:01 Wed 17 Mar 2021, Randy Dunlap wrote:
>On 3/17/21 10:54 AM, Reinette Chatre wrote:
>> Hi Bhaskar,
>>
>> Thank you very much for catching this typo.
>>
>> My feedback [1] to a previous patch from you applies here also. The prefix should be "x86/resctrl:" for contributions to this area.
>
>Bhaskar,
>Pretty much all of your patches need to have improved Subject: lines.
>The file name that is being modified should not be at the end of the Subject.
>
Noted, ...I was trying to feed the owner of the file as much as possible , so
the person can struggle less to understand and hover,considering the load they
might have on their shoulder.
>>
>> [1] https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
>>
>> On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>>>
>>> s/derefence/dereference/
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> index e916646adc69..43990a882b36 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>>> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
>>> * If the thread does not get on the CPU for whatever
>>> * reason and the process which sets up the region is
>>> * interrupted then this will leave the thread in runnable
>>> - * state and once it gets on the CPU it will derefence
>>> + * state and once it gets on the CPU it will dereference
>>> * the cleared, but not freed, plr struct resulting in an
>>> * empty pseudo-locking loop.
>>> */
>>> --
>>> 2.30.2
>>>
>>
>> Reinette
>
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 17:54 ` Reinette Chatre
2021-03-17 18:01 ` Randy Dunlap
@ 2021-03-17 19:33 ` Bhaskar Chowdhury
2021-03-17 20:31 ` Reinette Chatre
1 sibling, 1 reply; 7+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-17 19:33 UTC (permalink / raw)
To: Reinette Chatre
Cc: fenghua.yu, tglx, mingo, bp, x86, hpa, linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]
On 10:54 Wed 17 Mar 2021, Reinette Chatre wrote:
>Hi Bhaskar,
>
>Thank you very much for catching this typo.
>
>My feedback [1] to a previous patch from you applies here also. The
>prefix should be "x86/resctrl:" for contributions to this area.
>
Thanks for the heads up! Do you want another revision of it, or will you
take it as it is??? I am noting down your point ,so ,I might pull out next
time I intend to sent out something to this specific area.
>[1]
>https://lore.kernel.org/lkml/7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com/
>
>On 3/17/2021 1:40 AM, Bhaskar Chowdhury wrote:
>>
>> s/derefence/dereference/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> index e916646adc69..43990a882b36 100644
>> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
>> @@ -1307,7 +1307,7 @@ int rdtgroup_pseudo_lock_create(struct rdtgroup *rdtgrp)
>> * If the thread does not get on the CPU for whatever
>> * reason and the process which sets up the region is
>> * interrupted then this will leave the thread in runnable
>> - * state and once it gets on the CPU it will derefence
>> + * state and once it gets on the CPU it will dereference
>> * the cleared, but not freed, plr struct resulting in an
>> * empty pseudo-locking loop.
>> */
>> --
>> 2.30.2
>>
>
>Reinette
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 19:33 ` Bhaskar Chowdhury
@ 2021-03-17 20:31 ` Reinette Chatre
2021-03-17 22:21 ` Bhaskar Chowdhury
0 siblings, 1 reply; 7+ messages in thread
From: Reinette Chatre @ 2021-03-17 20:31 UTC (permalink / raw)
To: Bhaskar Chowdhury, fenghua.yu, tglx, mingo, bp, x86, hpa,
linux-kernel, rdunlap
Hi Bhaskar,
On 3/17/2021 12:33 PM, Bhaskar Chowdhury wrote:
> On 10:54 Wed 17 Mar 2021, Reinette Chatre wrote:
>> Thank you very much for catching this typo.
>>
>> My feedback [1] to a previous patch from you applies here also. The
>> prefix should be "x86/resctrl:" for contributions to this area.
>>
> Thanks for the heads up!
This was the third time I mention this to you.
> Do you want another revision of it, or will you
> take it as it is???
If accepted I am not the one who will merge this patch so having a
version that is ready for merge (all feedback addressed) would be best.
> I am noting down your point ,so ,I might pull out next
> time I intend to sent out something to this specific area.
Please do note that my comment was not specific to resctrl. This prefix
style is used by x86 area.
Reinette
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c
2021-03-17 20:31 ` Reinette Chatre
@ 2021-03-17 22:21 ` Bhaskar Chowdhury
0 siblings, 0 replies; 7+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-17 22:21 UTC (permalink / raw)
To: Reinette Chatre
Cc: fenghua.yu, tglx, mingo, bp, x86, hpa, linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On 13:31 Wed 17 Mar 2021, Reinette Chatre wrote:
>Hi Bhaskar,
>
>On 3/17/2021 12:33 PM, Bhaskar Chowdhury wrote:
>> On 10:54 Wed 17 Mar 2021, Reinette Chatre wrote:
>>> Thank you very much for catching this typo.
>>>
>>> My feedback [1] to a previous patch from you applies here also. The
>>> prefix should be "x86/resctrl:" for contributions to this area.
>>>
>> Thanks for the heads up!
>
>This was the third time I mention this to you.
>
Meh ...heck..that means something more important than your words occupied my
mind ...anyway...
>> Do you want another revision of it, or will you
>> take it as it is???
>
>If accepted I am not the one who will merge this patch so having a
>version that is ready for merge (all feedback addressed) would be best.
>
Thanks for the explanations.
>> I am noting down your point ,so ,I might pull out next
>> time I intend to sent out something to this specific area.
>
>Please do note that my comment was not specific to resctrl. This prefix
>style is used by x86 area.
>
I do understand.
>Reinette
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-17 22:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 8:40 [PATCH] kernel: cpu: resctrl: Minor typo fix in the file pseudo_lock.c Bhaskar Chowdhury
2021-03-17 17:54 ` Reinette Chatre
2021-03-17 18:01 ` Randy Dunlap
2021-03-17 19:29 ` Bhaskar Chowdhury
2021-03-17 19:33 ` Bhaskar Chowdhury
2021-03-17 20:31 ` Reinette Chatre
2021-03-17 22:21 ` Bhaskar Chowdhury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).