From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875B0C3F2D7 for ; Mon, 2 Mar 2020 13:48:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67B7321739 for ; Mon, 2 Mar 2020 13:48:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbgCBNsY (ORCPT ); Mon, 2 Mar 2020 08:48:24 -0500 Received: from foss.arm.com ([217.140.110.172]:32932 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726300AbgCBNsY (ORCPT ); Mon, 2 Mar 2020 08:48:24 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90C8E2F; Mon, 2 Mar 2020 05:48:23 -0800 (PST) Received: from [10.163.1.119] (unknown [10.163.1.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 83AAE3F534; Mon, 2 Mar 2020 05:48:16 -0800 (PST) Subject: Re: Linux-next-20200302: arm64 build failed To: Will Deacon , Naresh Kamboju , catalin.marinas@arm.com Cc: Linux-Next Mailing List , rppt@linux.ibm.com, Linux Kernel Mailing List , Stephen Rothwell , Arnd Bergmann , lkft-triage@lists.linaro.org, Andrew Morton , suzuki.poulose@arm.com, Anders Roxell References: <20200302104726.GA7995@willie-the-truck> From: Anshuman Khandual Message-ID: Date: Mon, 2 Mar 2020 19:18:16 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200302104726.GA7995@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2020 04:17 PM, Will Deacon wrote: > [+Anshuman and Catalin] > > On Mon, Mar 02, 2020 at 01:58:26PM +0530, Naresh Kamboju wrote: >> Linux-Next 20200302 arm64 build failed due to below errors, >> Suspecting patch causing this build break. >> >> 87d900aef3e2 arm/arm64: add support for folded p4d page tables >> >> Error log, >> ------------- >> arch/arm64/mm/mmu.c: In function 'unmap_hotplug_pud_range': >> include/linux/compiler.h:284:1: error: incompatible type for argument >> 1 of 'p4d_page_paddr' >> ({ \ >> ^ >> arch/arm64/include/asm/memory.h:270:45: note: in definition of macro >> '__phys_to_virt' >> #define __phys_to_virt(x) ((unsigned long)((x) - physvirt_offset)) >> ^ >> arch/arm64/include/asm/pgtable.h:629:42: note: in expansion of macro '__va' >> #define pud_offset(dir, addr) ((pud_t *)__va(pud_offset_phys((dir), (addr)))) >> ^~~~ >> include/linux/compiler.h:293:22: note: in expansion of macro '__READ_ONCE' >> #define READ_ONCE(x) __READ_ONCE(x, 1) >> ^~~~~~~~~~~ >> arch/arm64/include/asm/pgtable.h:628:52: note: in expansion of macro 'READ_ONCE' >> #define pud_offset_phys(dir, addr) (p4d_page_paddr(READ_ONCE(*(dir))) >> + pud_index(addr) * sizeof(pud_t)) >> ^~~~~~~~~ >> arch/arm64/include/asm/pgtable.h:629:47: note: in expansion of macro >> 'pud_offset_phys' >> #define pud_offset(dir, addr) ((pud_t *)__va(pud_offset_phys((dir), (addr)))) >> ^~~~~~~~~~~~~~~ >> arch/arm64/mm/mmu.c:827:10: note: in expansion of macro 'pud_offset' >> pudp = pud_offset(pgdp, addr); >> ^~~~~~~~~~ > > Looks like we need an implementation of unmap_hotplug_p4d_range() to > walk the dummy p4d level. Unfortunately, we don't have the folded p4d > patches in the arm64 tree so we'll either need a common branch or the > hotplug patches will need to be dropped for the moment. If we decide to get a common branch, will try to get this sorted with an unmap_hotplug_p4d_range() implementation as you have suggested. > > Will >