From: Dmitry Safonov <dima@arista.com>
To: YueHaibing <yuehaibing@huawei.com>,
shuah@kernel.org, tglx@linutronix.de, 0x7f454c46@gmail.com,
avagin@gmail.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] selftests/timens: Remove duplicated include <time.h>
Date: Fri, 6 Mar 2020 14:49:18 +0000 [thread overview]
Message-ID: <d2dd6da8-b24c-ead8-f66e-2a8c532a8830@arista.com> (raw)
In-Reply-To: <20200306031705.25008-1-yuehaibing@huawei.com>
On 3/6/20 3:17 AM, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for the cleanup,
Reviewed-by: Dmitry Safonov <dima@arista.com>
> ---
> tools/testing/selftests/timens/exec.c | 1 -
> tools/testing/selftests/timens/procfs.c | 1 -
> tools/testing/selftests/timens/timens.c | 1 -
> tools/testing/selftests/timens/timer.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/timens/exec.c b/tools/testing/selftests/timens/exec.c
> index 87b47b5..e40dc5b 100644
> --- a/tools/testing/selftests/timens/exec.c
> +++ b/tools/testing/selftests/timens/exec.c
> @@ -11,7 +11,6 @@
> #include <sys/wait.h>
> #include <time.h>
> #include <unistd.h>
> -#include <time.h>
> #include <string.h>
>
> #include "log.h"
> diff --git a/tools/testing/selftests/timens/procfs.c b/tools/testing/selftests/timens/procfs.c
> index 43d93f4..7f14f0f 100644
> --- a/tools/testing/selftests/timens/procfs.c
> +++ b/tools/testing/selftests/timens/procfs.c
> @@ -12,7 +12,6 @@
> #include <sys/types.h>
> #include <time.h>
> #include <unistd.h>
> -#include <time.h>
>
> #include "log.h"
> #include "timens.h"
> diff --git a/tools/testing/selftests/timens/timens.c b/tools/testing/selftests/timens/timens.c
> index 559d26e..098be7c 100644
> --- a/tools/testing/selftests/timens/timens.c
> +++ b/tools/testing/selftests/timens/timens.c
> @@ -10,7 +10,6 @@
> #include <sys/types.h>
> #include <time.h>
> #include <unistd.h>
> -#include <time.h>
> #include <string.h>
>
> #include "log.h"
> diff --git a/tools/testing/selftests/timens/timer.c b/tools/testing/selftests/timens/timer.c
> index 0cca7aa..96dba11 100644
> --- a/tools/testing/selftests/timens/timer.c
> +++ b/tools/testing/selftests/timens/timer.c
> @@ -11,7 +11,6 @@
> #include <stdio.h>
> #include <stdint.h>
> #include <signal.h>
> -#include <time.h>
>
> #include "log.h"
> #include "timens.h"
>
prev parent reply other threads:[~2020-03-06 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 3:17 [PATCH -next] selftests/timens: Remove duplicated include <time.h> YueHaibing
2020-03-06 14:49 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2dd6da8-b24c-ead8-f66e-2a8c532a8830@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).