From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: menglong8.dong@gmail.com, paulburton@kernel.org
Cc: tsbogend@alpha.franken.de, dong.menglong@zte.com.cn,
colin.king@canonical.com, gustavo@embeddedor.com,
ralf@linux-mips.org, peter.swain@cavium.com,
aleksey.makarov@auriga.com, lrosenboim@caviumnetworks.com,
david.daney@cavium.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu
Date: Mon, 11 Jan 2021 12:59:09 +0100 [thread overview]
Message-ID: <d2ed48b2-2043-a9f1-ea7a-2fb5c4027c57@nokia.com> (raw)
In-Reply-To: <20210111113605.3863-1-dong.menglong@zte.com.cn>
Hello Menglong!
Thank you for the fix! A small correction below:
On 11/01/2021 12:36, menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
>
> The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
> can't be true.
>
> Fix this by change the type of 'r' and 'i' from 'unsigned int'
> to 'int'. As 'i' won't be negative, this change works.
>
> Fixes: 64b139f97c01("MIPS: OCTEON: irq: add CIB and other fixes")
The patch actually fixes my commit 99fbc70f8547
("MIPS: Octeon: irq: Alloc desc before configuring IRQ").
With "Fixes:" tag corrected, you can put my
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index bd47e15d02c7..be5d4afcd30f 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -1444,7 +1444,7 @@ static void octeon_irq_setup_secondary_ciu2(void)
> static int __init octeon_irq_init_ciu(
> struct device_node *ciu_node, struct device_node *parent)
> {
> - unsigned int i, r;
> + int i, r;
> struct irq_chip *chip;
> struct irq_chip *chip_edge;
> struct irq_chip *chip_mbox;
>
--
Best regards,
Alexander Sverdlin.
prev parent reply other threads:[~2021-01-11 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 11:36 [PATCH] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu menglong8.dong
2021-01-11 11:59 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2ed48b2-2043-a9f1-ea7a-2fb5c4027c57@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=aleksey.makarov@auriga.com \
--cc=colin.king@canonical.com \
--cc=david.daney@cavium.com \
--cc=dong.menglong@zte.com.cn \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lrosenboim@caviumnetworks.com \
--cc=menglong8.dong@gmail.com \
--cc=paulburton@kernel.org \
--cc=peter.swain@cavium.com \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).