From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org, aik@ozlabs.ru,
david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org,
nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca
Subject: Re: [PATCH v5 3/3] tpm: ibmvtpm: Add support for TPM 2
Date: Wed, 4 Mar 2020 08:18:07 -0500 [thread overview]
Message-ID: <d2fda6ef-0c1e-7e20-08a2-44987564b7e1@linux.ibm.com> (raw)
In-Reply-To: <20200303201104.GG5775@linux.intel.com>
On 3/3/20 3:11 PM, Jarkko Sakkinen wrote:
> On Mon, Mar 02, 2020 at 11:21:27AM -0500, Stefan Berger wrote:
>> On 3/2/20 6:15 AM, Jarkko Sakkinen wrote:
>>> On Thu, Feb 27, 2020 at 10:03:30PM -0500, Stefan Berger wrote:
>>>> From: Stefan Berger <stefanb@linux.ibm.com>
>>>>
>>>> Support TPM 2 in the IBM vTPM driver. The hypervisor tells us what
>>>> version of TPM is connected through the vio_device_id.
>>> I'd prefer "TPM2" over "TPM 2".
>> Fixed.
>>>> In case a TPM 2 is found, we set the TPM_CHIP_FLAG_TPM2 flag
>>>> and get the command codes attributes table. The driver does
>>>> not need the timeouts and durations, though.
>>> A TPM2 what? TPM2 is not a thing.
>>
>> I don't know what you mean? Is it the word 'found' and it should be
>> 'present' ? Otherwise a TPM2 is a 'thing' / object / device, at least to me.
> TPM2 chip would be better. TPM2 can refer either to the protocol or to a
> chip.
Let's call it 'device', which in this case is a virtual device rather
than a 'virtual chip.'
Stefan
>
> /Jarkko
prev parent reply other threads:[~2020-03-04 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 3:03 [PATCH v5 0/3] Enable vTPM 2.0 for the IBM vTPM driver Stefan Berger
2020-02-28 3:03 ` [PATCH v5 1/3] tpm: of: Handle IBM,vtpm20 case when getting log parameters Stefan Berger
2020-02-28 3:03 ` [PATCH v5 2/3] tpm: ibmvtpm: Wait for buffer to be set before proceeding Stefan Berger
2020-03-02 11:11 ` Jarkko Sakkinen
2020-03-02 17:57 ` Nayna
2020-02-28 3:03 ` [PATCH v5 3/3] tpm: ibmvtpm: Add support for TPM 2 Stefan Berger
2020-03-02 11:15 ` Jarkko Sakkinen
2020-03-02 16:21 ` Stefan Berger
2020-03-03 20:11 ` Jarkko Sakkinen
2020-03-04 13:18 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2fda6ef-0c1e-7e20-08a2-44987564b7e1@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=gcwilson@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).