From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752552AbdKHULE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 15:11:04 -0500
Received: from mga14.intel.com ([192.55.52.115]:52781 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752396AbdKHULD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 15:11:03 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,365,1505804400"; 
   d="scan'208";a="147600709"
Subject: Re: [PATCH 01/30] x86, mm: do not set _PAGE_USER for init_mm page
 tables
To: Linus Torvalds <torvalds@linux-foundation.org>
References: <20171108194646.907A1942@viggo.jf.intel.com>
 <20171108194647.ABC9BC79@viggo.jf.intel.com>
 <CA+55aFwuFT48RS=Bn9qvgjr+2r+jNroQHw1F+G_GxtU12nJmaw@mail.gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>, Thomas Gleixner <tglx@linutronix.de>,
        moritz.lipp@iaik.tugraz.at, Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
        michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at,
        Andrew Lutomirski <luto@kernel.org>, Kees Cook <keescook@google.com>,
        Hugh Dickins <hughd@google.com>,
        the arch/x86 maintainers <x86@kernel.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <d30dd5bc-ca45-6bd9-5671-12980e1b3d8c@linux.intel.com>
Date: Wed, 8 Nov 2017 12:11:01 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CA+55aFwuFT48RS=Bn9qvgjr+2r+jNroQHw1F+G_GxtU12nJmaw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/08/2017 11:52 AM, Linus Torvalds wrote:
> On Wed, Nov 8, 2017 at 11:46 AM, Dave Hansen
> <dave.hansen@linux.intel.com> wrote:
>>
>> +
>>  static inline void pmd_populate_kernel(struct mm_struct *mm,
>>                                        pmd_t *pmd, pte_t *pte)
>>  {
>> +       pteval_t pgtable_flags = mm_pgtable_flags(mm);
> 
> Why is "pmd_populate_kernel()" using mm_pgtable_flags(mm)?
> 
> It should just use _KERNPG_TABLE unconditionally, shouldn't it?
> Nothing to do with init_mm, it's populating a _kernel_ page table
> regardless, no?

The end result is probably the same since a quick grep shows it only
ever getting called with init_mm or NULL.  But, yeah, it should probably
just be _PAGE_KERNEL directly.

I'll update it.