From: Dan Carpenter <error27@gmail.com>
To: Inshal Khan <kziaul123@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Staging: rtl8712: osdep_intf: Improve RND4 macro for better debugging and safety
Date: Tue, 21 Mar 2023 16:36:54 +0300 [thread overview]
Message-ID: <d3307a75-fcc0-4a94-8a05-05b871f4fa9f@kili.mountain> (raw)
In-Reply-To: <ZBmX9cjTRNhwt2zA@mehmed-HP-Pavilion-Laptop-15-eh2xxx>
On Tue, Mar 21, 2023 at 05:11:41PM +0530, Inshal Khan wrote:
> drivers/staging/rtl8712/osdep_intf.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 95a21f380cd7..0e097b4a8670 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -18,8 +18,8 @@
> #include "drv_types.h"
>
> #define RND4(x) ({ \
> - typeof(x) _x = (x); \
> - (((_x) + 3) & ~3); \
> + typeof(x) _x = (x); \
> + (((_x) + 3) & ~3); \
Just use normal kernel rounding macros and delete RND4().
regards,
dan carpenter
prev parent reply other threads:[~2023-03-21 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 11:41 [PATCH 4/4] Staging: rtl8712: osdep_intf: Improve RND4 macro for better debugging and safety Inshal Khan
2023-03-21 13:36 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3307a75-fcc0-4a94-8a05-05b871f4fa9f@kili.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kziaul123@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).