Re: [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.

From: Heiner Kallweit <hkallweit1@gmail.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Shannon Nelson <snelson@pensando.io>,
	Jakub Kicinski <kuba@kernel.org>,
	Martin Habets <mhabets@solarflare.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	netdev@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	bjorn@helgaas.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	rjw@rjwysocki.net
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-pm@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.
Date: Tue, 28 Apr 2020 19:54:12 +0200	[thread overview]
Message-ID: <d33991cc-c219-dc27-7559-f30dd5f4aa0a@gmail.com> (raw)
In-Reply-To: <20200428144314.24533-1-vaibhavgupta40@gmail.com>

On 28.04.2020 16:43, Vaibhav Gupta wrote:
> The purpose of this patch series is to remove legacy power management callbacks
> from realtek ethernet drivers.
> 
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
> themselves, which is not recommended.
> 
Did you test any of the changes? If not, then mention this at least.
A typical comment in the commit message would be "compile-tested only".

In addition the following should be changed.
[Linux-kernel-mentees] [PATCH v2 0/2]
Use
[PATCH net-next v2 0/2]
instead.

> The conversion requires the removal of the those function calls and change the
> callback definition accordingly.
> 
> Vaibhav Gupta (2):
>   realtek/8139too: Remove Legacy Power Management
>   realtek/8139cp: Remove Legacy Power Management
> 
>  drivers/net/ethernet/realtek/8139cp.c  | 25 +++++++------------------
>  drivers/net/ethernet/realtek/8139too.c | 26 +++++++-------------------
>  2 files changed, 14 insertions(+), 37 deletions(-)
> 