From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>, Matthew Wilcox <willy@infradead.org>
Cc: David Rientjes <rientjes@google.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: Sleeping BUG in khugepaged for i586
Date: Fri, 9 Jun 2017 08:48:58 +0200 [thread overview]
Message-ID: <d348054d-3857-65bb-e896-c4bd2ea6ee85@suse.cz> (raw)
In-Reply-To: <20170608203046.GB5535@dhcp22.suse.cz>
On 06/08/2017 10:30 PM, Michal Hocko wrote:
> But I guess you are primary after syncing the preemptive mode for 64 and
> 32b systems, right? I agree that having a different model is more than
> unfortunate because 32b gets much less testing coverage and so a risk of
> introducing a new bug is just a matter of time. Maybe we should make
> pte_offset_map disable preemption and currently noop pte_unmap to
> preempt_enable. The overhead should be pretty marginal on x86_64 but not
> all arches have per-cpu preempt count. So I am not sure we really want
> to add this to just for the debugging purposes...
I think adding that overhead for everyone would be unfortunate. It would
be acceptable, if it was done only for the config option that enables
the might_sleep() checks (CONFIG_DEBUG_ATOMIC_SLEEP?)
Vlastimil
next prev parent reply other threads:[~2017-06-09 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 19:24 Sleeping BUG in khugepaged for i586 Larry Finger
2017-06-05 21:44 ` Andrew Morton
2017-06-06 14:02 ` Vlastimil Babka
2017-06-06 15:01 ` Larry Finger
2017-06-07 7:19 ` Vlastimil Babka
2017-06-07 20:56 ` David Rientjes
2017-06-08 14:48 ` Michal Hocko
2017-06-08 17:05 ` Matthew Wilcox
2017-06-08 20:18 ` Michal Hocko
2017-06-08 20:30 ` Michal Hocko
2017-06-09 6:48 ` Vlastimil Babka [this message]
2017-06-09 7:43 ` Michal Hocko
2017-06-09 14:28 ` Larry Finger
2017-06-09 22:38 ` David Rientjes
2017-06-10 8:09 ` Michal Hocko
2017-06-11 23:28 ` David Rientjes
2017-06-12 6:29 ` Michal Hocko
2017-06-15 0:28 ` David Rientjes
2017-06-15 1:12 ` David Rientjes
2017-06-15 8:32 ` Michal Hocko
2017-06-23 12:08 ` Michal Hocko
2017-06-23 13:13 ` Vlastimil Babka
2017-06-23 13:25 ` Michal Hocko
2017-06-23 15:28 ` Larry Finger
2017-06-08 15:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d348054d-3857-65bb-e896-c4bd2ea6ee85@suse.cz \
--to=vbabka@suse.cz \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).