From: Joe Perches <joe@perches.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Zou Wei <zou_wei@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] perf script: remove unneeded conversion to bool
Date: Tue, 28 Apr 2020 14:58:46 -0700 [thread overview]
Message-ID: <d367cca3297fc07f5fc155f1e0b9b0e93c1b3cdf.camel@perches.com> (raw)
In-Reply-To: <20200428175046.GD5460@kernel.org>
On Tue, 2020-04-28 at 14:50 -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Apr 26, 2020 at 08:31:05PM +0800, Zou Wei escreveu:
> > This issue was detected by using the Coccinelle software:
> >
> > tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> > tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
> >
> > The conversion to bool is unneeded, remove it
>
> Thanks, applied,
Did you read the patch?
It's broken, unless some other patch was applied.
next prev parent reply other threads:[~2020-04-28 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 12:31 [PATCH -next] perf script: remove unneeded conversion to bool Zou Wei
2020-04-26 20:59 ` Joe Perches
2020-04-28 17:50 ` Arnaldo Carvalho de Melo
2020-04-28 21:58 ` Joe Perches [this message]
2020-04-28 23:08 ` Arnaldo Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d367cca3297fc07f5fc155f1e0b9b0e93c1b3cdf.camel@perches.com \
--to=joe@perches.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).