From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator
Date: Tue, 23 Jul 2019 10:07:30 +0200 [thread overview]
Message-ID: <d36c7925-1374-80e0-60e2-b08377be1f5f@st.com> (raw)
In-Reply-To: <20190723014102.25103-1-axel.lin@ingics.com>
On 7/23/19 3:41 AM, Axel Lin wrote:
> Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
> remove the redundant .min_uV and .list_voltage settings.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Hi Axel,
Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Thanks,
Fabrice
> ---
> drivers/regulator/stm32-booster.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
> index 2a897666c650..03f162ffd144 100644
> --- a/drivers/regulator/stm32-booster.c
> +++ b/drivers/regulator/stm32-booster.c
> @@ -20,7 +20,6 @@
> #define STM32MP1_SYSCFG_EN_BOOSTER_MASK BIT(8)
>
> static const struct regulator_ops stm32h7_booster_ops = {
> - .list_voltage = regulator_list_voltage_linear,
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
> .is_enabled = regulator_is_enabled_regmap,
> @@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
> .supply_name = "vdda",
> .n_voltages = 1,
> .type = REGULATOR_VOLTAGE,
> - .min_uV = 3300000,
> .fixed_uV = 3300000,
> .ramp_delay = 66000, /* up to 50us to stabilize */
> .ops = &stm32h7_booster_ops,
> @@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
> }
>
> static const struct regulator_ops stm32mp1_booster_ops = {
> - .list_voltage = regulator_list_voltage_linear,
> .enable = stm32mp1_booster_enable,
> .disable = stm32mp1_booster_disable,
> .is_enabled = regulator_is_enabled_regmap,
> @@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
> .supply_name = "vdda",
> .n_voltages = 1,
> .type = REGULATOR_VOLTAGE,
> - .min_uV = 3300000,
> .fixed_uV = 3300000,
> .ramp_delay = 66000,
> .ops = &stm32mp1_booster_ops,
>
next prev parent reply other threads:[~2019-07-23 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 1:41 [PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator Axel Lin
2019-07-23 8:07 ` Fabrice Gasnier [this message]
2019-07-23 11:29 ` Applied "regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d36c7925-1374-80e0-60e2-b08377be1f5f@st.com \
--to=fabrice.gasnier@st.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).