From: Jon Hunter <jonathanh@nvidia.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Hans de Goede <hdegoede@redhat.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
<linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [REGRESSION] brcmfmac: NULL pointer deference starting next-20181107
Date: Tue, 13 Nov 2018 11:29:19 +0000 [thread overview]
Message-ID: <d3783759-9030-76bc-d218-6f92b462de7f@nvidia.com> (raw)
In-Reply-To: <9f72ac4f-a83a-7af7-3c26-b1ced6d98653@broadcom.com>
Hi Arend,
On 13/11/2018 10:24, Arend van Spriel wrote:
...
> I tried building drivers/firmware/efi/vars.c using tegra_defconfig. Had
> to enable CONFIG_EFI. So the null pointer access is a 0x00000008 so I
> looked at the disassembly below:
>
> int efivar_entry_size(struct efivar_entry *entry, unsigned long *size)
> {
> 310: e1a05001 mov r5, r1
> const struct efivar_operations *ops = __efivars->ops;
> ==> 314: e5936008 ldr r6, [r3, #8]
>
> So I think __efivars is NULL on your platform. It is private to the
> source file. Not sure how the driver should deal with this. Maybe use
> efi_enabled() but not sure what feature to use. My best bet would be
> EFI_RUNTIME_SERVICES.
>
> efi_status_t status;
>
> *size = 0;
> 318: e3a03000 mov r3, #0
> 31c: e5813000 str r3, [r1]
>
> if (down_interruptible(&efivars_lock))
> 320: ebfffffe bl 0 <down_interruptible>
> 324: e2504000 subs r4, r0, #0
> 328: 1a000012 bne 378 <efivar_entry_size+0x80>
> return -EINTR;
> status = ops->get_variable(entry->var.VariableName,
So actually, I am seeing the crash with the 'multi_v7_defconfig' and I
don't see it with the 'tegra_defconfig' (probably because CONFIG_EFI is
not enabled).
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2018-11-13 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 13:24 [REGRESSION] brcmfmac: NULL pointer deference starting next-20181107 Jon Hunter
2018-11-12 13:25 ` Jon Hunter
2018-11-13 10:24 ` Arend van Spriel
2018-11-13 10:33 ` Arend van Spriel
2018-11-13 10:40 ` Hans de Goede
2018-11-13 10:45 ` Arend van Spriel
2018-11-13 13:21 ` Jon Hunter
2018-11-13 13:32 ` Jon Hunter
2018-11-13 13:32 ` Hans de Goede
2018-11-13 11:29 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3783759-9030-76bc-d218-6f92b462de7f@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arend.vanspriel@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).