From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978AbdHXIyH (ORCPT ); Thu, 24 Aug 2017 04:54:07 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:45826 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbdHXIyF (ORCPT ); Thu, 24 Aug 2017 04:54:05 -0400 Subject: Re: [PATCH][next] net: hinic: fix comparison of a uint16_t type with -1 To: Aviad Krawczyk , netdev@vger.kernel.org References: <20170823153936.22857-1-colin.king@canonical.com> <58f312cc-5f24-83b6-d12d-c66e4fd4dad2@huawei.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: Date: Thu, 24 Aug 2017 09:54:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <58f312cc-5f24-83b6-d12d-c66e4fd4dad2@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/08/17 09:48, Aviad Krawczyk wrote: > On 8/23/2017 6:39 PM, Colin King wrote: >> From: Colin Ian King >> >> The comparison of hw_ioctxt.rx_buf_sz_idx == -1 is always false because >> rx_buf_sz_idx is a uint16_t. Fix this by explicitly casting -1 to uint16_t. >> >> Detected by CoverityScan, CID#1454559 ("Operands don't affect result") >> >> Signed-off-by: Colin Ian King >> --- >> drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c >> index 09dec6de8dd5..71e26070fb7f 100644 >> --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c >> +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c >> @@ -352,7 +352,7 @@ static int set_hw_ioctxt(struct hinic_hwdev *hwdev, unsigned int rq_depth, >> } >> } >> >> - if (hw_ioctxt.rx_buf_sz_idx == -1) >> + if (hw_ioctxt.rx_buf_sz_idx == (uint16_t)-1) >> return -EINVAL; >> >> hw_ioctxt.sq_depth = ilog2(sq_depth); >> > > Many thanks, Colin. > I prefer to avoid casting when possible, what do you think about replacing the condition by: > > if (rx_buf_sz_table[i].sz != HINIC_RX_BUF_SZ) > return -EINVAL; > Does that work as expected when rx_buf_sz_table[i].sz == -1?