From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CE0C4332F for ; Tue, 5 Apr 2022 12:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359365AbiDEL5A (ORCPT ); Tue, 5 Apr 2022 07:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244976AbiDEIww (ORCPT ); Tue, 5 Apr 2022 04:52:52 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E55C1D0DD; Tue, 5 Apr 2022 01:48:24 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id D943E221D4; Tue, 5 Apr 2022 10:48:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1649148502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/+zyXUcDmdndIIui1WDqypJvYDMYDrXZERNBQ0ecKk=; b=aveEuHEhPZQK2Uwn++JVqUY23++YtQ2Iog5KE9xDadFiSBB9b3U5iB3yh8MN6rQH3Ij9Jq W4neXVvnU1lja2kSQ35ur8KKaEpcANmZUPVFd3h1XfmeGmmaenwP4aZ/Jaw3UgCKWoM+A7 hJOlxIxVSNwizXEPqxE9Sj9Sd59uUbo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Apr 2022 10:48:21 +0200 From: Michael Walle To: Richard Cochran Cc: Andrew Lunn , davem@davemloft.net, grygorii.strashko@ti.com, kuba@kernel.org, kurt@linutronix.de, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, mlichvar@redhat.com, netdev@vger.kernel.org, qiangqing.zhang@nxp.com, vladimir.oltean@nxp.com, Horatiu Vultur Subject: Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable. In-Reply-To: <20220405055954.GB91955@hoboy.vegasvil.org> References: <20220104014215.GA20062@hoboy.vegasvil.org> <20220404150508.3945833-1-michael@walle.cc> <20220405055954.GB91955@hoboy.vegasvil.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-04-05 07:59, schrieb Richard Cochran: > On Mon, Apr 04, 2022 at 07:12:11PM +0200, Michael Walle wrote: > >> That would make sense. I guess what bothers me with the current >> mechanism is that a feature addition to the PHY in the *future* (the >> timestamping support) might break a board - or at least changes the >> behavior by suddenly using PHY timestamping. > > That is a good point, but then something will break in any case. Can the ethernet driver select the default one? So any current driver which has "if phy_has_hwtstamp() forward_ioctl;" can set it to PHY while newer drivers can (or should actually) leave it as MAC. This doesn't really fix the problem per se. But at least new drivers won't be affected. For my problem at hand, I'd need to convince Microchip to default to MAC although the driver is already in the tree (but there is no user of it in mainline right now). -michael