From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753424AbdLHVvf (ORCPT ); Fri, 8 Dec 2017 16:51:35 -0500 Received: from mout.web.de ([212.227.15.4]:59692 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbdLHVva (ORCPT ); Fri, 8 Dec 2017 16:51:30 -0500 Subject: [PATCH 1/3] serial: ioc4: Delete error messages for a failed memory allocation in two functions From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Pat Gefre Cc: LKML , kernel-janitors@vger.kernel.org References: <514232dd-7e91-00f9-b95c-3e8f740090ca@users.sourceforge.net> Message-ID: Date: Fri, 8 Dec 2017 22:51:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <514232dd-7e91-00f9-b95c-3e8f740090ca@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:02YqHpOYOF13b/nC5MpER8VSjLwNf+TCoRQuopxXj9QHf0LFfky 4w0QXf1+ZSasviTNibYzogmQpyYcXx1DhpS3qhpoWV0ylvCobtWK4TwFooFSYd+R10le590 Bey/RfGBw74J1zOEHSzkBEPKGJ7CPeh1p9zwLsRlzl3WGz2iOoR0MtkstIY7wwBOfaVg/dC FIEmRwcEH2C413TfqdUBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:kRhyRMvhe9w=:H5r3rZngwqFFsM0iQSaDJZ l7yxLcsedsREa0K9AELcRZhPrTE6zz5mma2ayk+sfa2wElClwAJvAGmi3958QBcCJZBOJkABK krO48UkKq+2pp7rvI4SN5nCHRJA0N/XUSyGzTr822tHELp6hmoM233FDkaKgbuhemfAVAMvqE Z2qDfxgslZKWk3VECCKrm9/gVYcVk3HE/8p02xX3ydXSAvpG+HhE+L/tKSz4uWyCbuO7OsKlQ c4BO/9qz+trDT+HzW4CawQS/4EIK2wOxvk/kZIXu+2eCKxh7kD78hKY6wl1Q8Gors7h9sis5x vSc9RzqTH7Y3ANJNTFlTA0LrxroVgY8JA3u84aaPSXLlIuc8XHqAVIbprCO3wCFCd5ITSR652 qkaNnVIw5RqKoNc1xJ1YGgjBKrFG7I8M2Jc5/adg5XptNCE4BDs1DnRrsiWt5qJxZByF+6SPa o9Dhi0oOyVYX+aaKZ3O6D5vcKiOr1GAmPE7XDcAQfaZ7vHyXB78G1MMTu6f5+FiAZCxzx2+DP XOaHYI9tDh5T6w06aAkmG6nn2PAZJg5vMzeQc5Uchc+3m7ux2ORCMoFU54Ce2YokAQr6jCNMi tGeFEZepFchmkVZ8DQHTeCUMcA/g11alKduX1+WX27QukJZTjX4nRoEp6+VdeFwwClQZTsfUX 1d84+1yX7iXyJOXDoPwY9uO6CA5kfnctiYNGh2Gzl8VKAExq3QYglTlvLIhSxeCnOmJAoPjPL buGrsmfRjNAM80kYVPv1pWLqkVMzdCiBNe4n1QGpVadO3VXjNV4aMNyY1PITmIuJ144cegpy+ CoiWFMiv6H8sP0knKtYR/q0nvL5HWYIcpnqjuOi9oFoo5+NzfQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 22:15:53 +0100 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ioc4_serial.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/ioc4_serial.c b/drivers/tty/serial/ioc4_serial.c index db5b979e5a0c..9524a6d3e1d8 100644 --- a/drivers/tty/serial/ioc4_serial.c +++ b/drivers/tty/serial/ioc4_serial.c @@ -1076,11 +1076,9 @@ static inline int ioc4_attach_local(struct ioc4_driver_data *idd) for (port_number = 0; port_number < IOC4_NUM_SERIAL_PORTS; port_number++) { port = kzalloc(sizeof(struct ioc4_port), GFP_KERNEL); - if (!port) { - printk(KERN_WARNING - "IOC4 serial memory not available for port\n"); + if (!port) goto free; - } + spin_lock_init(&port->ip_lock); /* we need to remember the previous ones, to point back to @@ -2815,8 +2813,6 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) control = kzalloc(sizeof(struct ioc4_control), GFP_KERNEL); if (!control) { - printk(KERN_WARNING "ioc4_attach_one" - ": unable to get memory for the IOC4\n"); ret = -ENOMEM; goto out2; } @@ -2825,9 +2821,6 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) /* Allocate the soft structure */ soft = kzalloc(sizeof(struct ioc4_soft), GFP_KERNEL); if (!soft) { - printk(KERN_WARNING - "ioc4 (%p): unable to get memory for the soft struct\n", - (void *)idd->idd_pdev); ret = -ENOMEM; goto out3; } -- 2.15.1