* [PATCH v6] arm64: dts: qcom: sdm845: Add Q6V5 MSS node
@ 2019-01-14 19:22 Sibi Sankar
2019-01-17 23:05 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Sibi Sankar @ 2019-01-14 19:22 UTC (permalink / raw)
To: bjorn.andersson, robh+dt, andy.gross, david.brown, dianders
Cc: linux-arm-msm, linux-soc, devicetree, linux-kernel, tsoni, clew,
akdwived, mark.rutland, linux-remoteproc, evgreen, briannorris,
sricharan, Sibi Sankar
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v6:
* Drop unused mbox-names property
* Add mss_pil label
* Rebased to Andy's for-next
v5:
* Use qmp_aop updated dt binding
v3:
* with shutdown-ack irq redesign make it mandatory,
merge multiple patches into a single one
v2:
* Fixed style changes
* Added missing clocks in the dt-bindings
* Split mss remoteproc node into a number of patches
This patch depends on the following bindings:
https://patchwork.kernel.org/patch/10662089/ - mba/mpss reserved regions
https://patchwork.kernel.org/patch/10657325/ - pdc reset node
https://patchwork.kernel.org/patch/10755191/ - rpmhpd dt node
https://patchwork.kernel.org/patch/10755197/ - rpmhpd dt binding
https://patchwork.kernel.org/patch/10749469/ - AOP QMP dt binding
https://patchwork.kernel.org/patch/10751757/ - shutdown-irq binding
arch/arm64/boot/dts/qcom/sdm845.dtsi | 59 ++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 7d05e967c9ee..b5a58e508bb2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1440,6 +1440,65 @@
};
};
+ mss_pil: remoteproc@4080000 {
+ compatible = "qcom,sdm845-mss-pil";
+ reg = <0x04080000 0x408>, <0x04180000 0x48>;
+ reg-names = "qdsp6", "rmb";
+
+ interrupts-extended =
+ <&intc GIC_SPI 266 IRQ_TYPE_EDGE_RISING>,
+ <&modem_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&modem_smp2p_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&modem_smp2p_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&modem_smp2p_in 3 IRQ_TYPE_EDGE_RISING>,
+ <&modem_smp2p_in 7 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog", "fatal", "ready",
+ "handover", "stop-ack",
+ "shutdown-ack";
+
+ clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
+ <&gcc GCC_MSS_Q6_MEMNOC_AXI_CLK>,
+ <&gcc GCC_BOOT_ROM_AHB_CLK>,
+ <&gcc GCC_MSS_GPLL0_DIV_CLK_SRC>,
+ <&gcc GCC_MSS_SNOC_AXI_CLK>,
+ <&gcc GCC_MSS_MFAB_AXIS_CLK>,
+ <&gcc GCC_PRNG_AHB_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "iface", "bus", "mem", "gpll0_mss",
+ "snoc_axi", "mnoc_axi", "prng", "xo";
+
+ qcom,smem-states = <&modem_smp2p_out 0>;
+ qcom,smem-state-names = "stop";
+
+ resets = <&aoss_reset AOSS_CC_MSS_RESTART>,
+ <&pdc_reset PDC_MODEM_SYNC_RESET>;
+ reset-names = "mss_restart", "pdc_reset";
+
+ qcom,halt-regs = <&tcsr_mutex_regs
+ 0x23000 0x25000 0x24000>;
+
+ power-domains = <&aoss_qmp AOSS_QMP_LS_MODEM>,
+ <&rpmhpd SDM845_CX>,
+ <&rpmhpd SDM845_MX>,
+ <&rpmhpd SDM845_MSS>;
+ power-domain-names = "load_state", "cx", "mx", "mss";
+
+ mba {
+ memory-region = <&mba_region>;
+ };
+
+ mpss {
+ memory-region = <&mpss_region>;
+ };
+
+ glink-edge {
+ interrupts = <GIC_SPI 449 IRQ_TYPE_EDGE_RISING>;
+ label = "modem";
+ qcom,remote-pid = <1>;
+ mboxes = <&apss_shared 12>;
+ };
+ };
+
sdhc_2: sdhci@8804000 {
compatible = "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5";
reg = <0x8804000 0x1000>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v6] arm64: dts: qcom: sdm845: Add Q6V5 MSS node
2019-01-14 19:22 [PATCH v6] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar
@ 2019-01-17 23:05 ` Doug Anderson
2019-01-18 5:21 ` Sibi Sankar
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2019-01-17 23:05 UTC (permalink / raw)
To: Sibi Sankar
Cc: Bjorn Andersson, Rob Herring, Andy Gross, David Brown,
linux-arm-msm, open list:ARM/QUALCOMM SUPPORT, devicetree, LKML,
tsoni, clew, akdwived, Mark Rutland, linux-remoteproc,
Evan Green, Brian Norris, sricharan
Hi,
On Mon, Jan 14, 2019 at 11:22 AM Sibi Sankar <sibis@codeaurora.org> wrote:
> + mss_pil: remoteproc@4080000 {
> + compatible = "qcom,sdm845-mss-pil";
> + reg = <0x04080000 0x408>, <0x04180000 0x48>;
This will now need to be adjusted to:
reg = <0 0x04080000 0 0x408>, <0 0x04180000 0 0x48>;
This fixes things up to deal with the patch ("arm64: dts: qcom:
sdm845: Increase address and size cells for soc"), AKA:
- https://patchwork.kernel.org/patch/10767511/
- https://lkml.kernel.org/r/20190117042940.25487-2-bjorn.andersson@linaro.org
-Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6] arm64: dts: qcom: sdm845: Add Q6V5 MSS node
2019-01-17 23:05 ` Doug Anderson
@ 2019-01-18 5:21 ` Sibi Sankar
0 siblings, 0 replies; 3+ messages in thread
From: Sibi Sankar @ 2019-01-18 5:21 UTC (permalink / raw)
To: Doug Anderson
Cc: Bjorn Andersson, Rob Herring, Andy Gross, David Brown,
linux-arm-msm, open list:ARM/QUALCOMM SUPPORT, devicetree, LKML,
tsoni, clew, akdwived, Mark Rutland, linux-remoteproc,
Evan Green, Brian Norris, sricharan, linux-soc-owner
On 2019-01-18 04:35, Doug Anderson wrote:
> Hi,
>
> On Mon, Jan 14, 2019 at 11:22 AM Sibi Sankar <sibis@codeaurora.org>
> wrote:
>> + mss_pil: remoteproc@4080000 {
>> + compatible = "qcom,sdm845-mss-pil";
>> + reg = <0x04080000 0x408>, <0x04180000 0x48>;
>
> This will now need to be adjusted to:
>
> reg = <0 0x04080000 0 0x408>, <0 0x04180000 0 0x48>;
Yup, this was on my todo list after Bjorn
posted out the patch
>
> This fixes things up to deal with the patch ("arm64: dts: qcom:
> sdm845: Increase address and size cells for soc"), AKA:
> - https://patchwork.kernel.org/patch/10767511/
> -
> https://lkml.kernel.org/r/20190117042940.25487-2-bjorn.andersson@linaro.org
>
>
> -Doug
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-18 5:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 19:22 [PATCH v6] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar
2019-01-17 23:05 ` Doug Anderson
2019-01-18 5:21 ` Sibi Sankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).