* [PATCH] powerpc/sysdev: fix compile errors
@ 2020-01-21 5:31 wangwenhu
2020-01-21 5:58 ` Christophe Leroy
2020-01-21 6:13 ` Andrew Donnellan
0 siblings, 2 replies; 13+ messages in thread
From: wangwenhu @ 2020-01-21 5:31 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Kate Stewart, Greg Kroah-Hartman, Richard Fontana,
Thomas Gleixner, wangwenhu, linuxppc-dev, linux-kernel
Cc: trivial, lonehugo, wenhu.wang
From: wangwenhu <wenhu.wang@vivo.com>
Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
fix the implicit declaration compile errors when building Cache-Sram.
arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
^~~~~~~~~~~~~~~~
bitmap_complement
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
^
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
iounmap(cache_sram->base_virt);
^~~~~~~
roundup
cc1: all warnings being treated as errors
Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
---
arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
index f6c665dac725..29b6868eff7d 100644
--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
@@ -17,6 +17,7 @@
#include <linux/of_platform.h>
#include <asm/pgtable.h>
#include <asm/fsl_85xx_cache_sram.h>
+#include <asm/io.h>
#include "fsl_85xx_cache_ctlr.h"
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 5:31 [PATCH] powerpc/sysdev: fix compile errors wangwenhu
@ 2020-01-21 5:58 ` Christophe Leroy
2020-01-21 6:13 ` Andrew Donnellan
1 sibling, 0 replies; 13+ messages in thread
From: Christophe Leroy @ 2020-01-21 5:58 UTC (permalink / raw)
To: wangwenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Richard Fontana, Thomas Gleixner, linuxppc-dev, linux-kernel
Cc: lonehugo, trivial, wenhu.wang
Le 21/01/2020 à 06:31, wangwenhu a écrit :
> From: wangwenhu <wenhu.wang@vivo.com>
>
> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
> fix the implicit declaration compile errors when building Cache-Sram.
It is usually better to include <linux/io.h> instead of <asm/io.h>
Christophe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 5:31 [PATCH] powerpc/sysdev: fix compile errors wangwenhu
2020-01-21 5:58 ` Christophe Leroy
@ 2020-01-21 6:13 ` Andrew Donnellan
2020-01-21 6:59 ` 王文虎
1 sibling, 1 reply; 13+ messages in thread
From: Andrew Donnellan @ 2020-01-21 6:13 UTC (permalink / raw)
To: wangwenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Richard Fontana, Thomas Gleixner, linuxppc-dev, linux-kernel
Cc: trivial, lonehugo, wenhu.wang
On 21/1/20 4:31 pm, wangwenhu wrote:
> From: wangwenhu <wenhu.wang@vivo.com>
>
> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
> fix the implicit declaration compile errors when building Cache-Sram.
>
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> ^~~~~~~~~~~~~~~~
> bitmap_complement
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> ^
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
> iounmap(cache_sram->base_virt);
> ^~~~~~~
> roundup
> cc1: all warnings being treated as errors
>
> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
How long has this code been broken for?
> ---
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> index f6c665dac725..29b6868eff7d 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <asm/pgtable.h>
> #include <asm/fsl_85xx_cache_sram.h>
> +#include <asm/io.h>
>
> #include "fsl_85xx_cache_ctlr.h"
>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re:Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 6:13 ` Andrew Donnellan
@ 2020-01-21 6:59 ` 王文虎
2020-01-21 8:21 ` Christophe Leroy
2020-01-21 8:37 ` Christophe Leroy
0 siblings, 2 replies; 13+ messages in thread
From: 王文虎 @ 2020-01-21 6:59 UTC (permalink / raw)
To: Andrew Donnellan
Cc: wangwenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Richard Fontana, Thomas Gleixner, linuxppc-dev, linux-kernel,
trivial, lonehugo
发件人：Andrew Donnellan <ajd@linux.ibm.com>
发送日期：2020-01-21 14:13:07
收件人：wangwenhu <wenhu.pku@gmail.com>,Benjamin Herrenschmidt <benh@kernel.crashing.org>,Paul Mackerras <paulus@samba.org>,Michael Ellerman <mpe@ellerman.id.au>,Kate Stewart <kstewart@linuxfoundation.org>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org
抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com
主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>> From: wangwenhu <wenhu.wang@vivo.com>
>>
>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>> fix the implicit declaration compile errors when building Cache-Sram.
>>
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>> ^~~~~~~~~~~~~~~~
>> bitmap_complement
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>> ^
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>> iounmap(cache_sram->base_virt);
>> ^~~~~~~
>> roundup
>> cc1: all warnings being treated as errors
>>
>> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
>
>How long has this code been broken for?
It's been broken almost 15 months since the commit below:
"commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
Author: Christophe Leroy <christophe.leroy@c-s.fr>
Date: Tue Oct 9 13:51:41 2018 +0000
powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."
And we are working on it now for further development.
>
>> ---
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> index f6c665dac725..29b6868eff7d 100644
>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> @@ -17,6 +17,7 @@
>> #include <linux/of_platform.h>
>> #include <asm/pgtable.h>
>> #include <asm/fsl_85xx_cache_sram.h>
>> +#include <asm/io.h>
>>
>> #include "fsl_85xx_cache_ctlr.h"
>>
>
>--
>Andrew Donnellan OzLabs, ADL Canberra
>ajd@linux.ibm.com IBM Australia Limited
>
Wenhu
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 6:59 ` 王文虎
@ 2020-01-21 8:21 ` Christophe Leroy
2020-01-21 8:37 ` Christophe Leroy
1 sibling, 0 replies; 13+ messages in thread
From: Christophe Leroy @ 2020-01-21 8:21 UTC (permalink / raw)
To: 王文虎, Andrew Donnellan
Cc: Kate Stewart, Richard Fontana, Greg Kroah-Hartman, linux-kernel,
wangwenhu, Paul Mackerras, trivial, Thomas Gleixner,
linuxppc-dev, lonehugo
Le 21/01/2020 à 07:59, 王文虎 a écrit :
> 发件人：Andrew Donnellan <ajd@linux.ibm.com>
> 发送日期：2020-01-21 14:13:07
> 收件人：wangwenhu <wenhu.pku@gmail.com>,Benjamin Herrenschmidt <benh@kernel.crashing.org>,Paul Mackerras <paulus@samba.org>,Michael Ellerman <mpe@ellerman.id.au>,Kate Stewart <kstewart@linuxfoundation.org>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org
> 抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com
> 主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>>> From: wangwenhu <wenhu.wang@vivo.com>
>>>
>>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>>> fix the implicit declaration compile errors when building Cache-Sram.
>>>
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>> ^~~~~~~~~~~~~~~~
>>> bitmap_complement
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>> ^
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>> iounmap(cache_sram->base_virt);
>>> ^~~~~~~
>>> roundup
>>> cc1: all warnings being treated as errors
>>>
>>> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
>>
>> How long has this code been broken for?
>
> It's been broken almost 15 months since the commit below:
> "commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
Can you then add a Fixes: tag ?
Thanks
Christophe
> Author: Christophe Leroy <christophe.leroy@c-s.fr>
> Date: Tue Oct 9 13:51:41 2018 +0000
>
> powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."
>
> And we are working on it now for further development.
>
>>
>>> ---
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> index f6c665dac725..29b6868eff7d 100644
>>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> @@ -17,6 +17,7 @@
>>> #include <linux/of_platform.h>
>>> #include <asm/pgtable.h>
>>> #include <asm/fsl_85xx_cache_sram.h>
>>> +#include <asm/io.h>
>>>
>>> #include "fsl_85xx_cache_ctlr.h"
>>>
>>
>> --
>> Andrew Donnellan OzLabs, ADL Canberra
>> ajd@linux.ibm.com IBM Australia Limited
>>
>
> Wenhu
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 6:59 ` 王文虎
2020-01-21 8:21 ` Christophe Leroy
@ 2020-01-21 8:37 ` Christophe Leroy
2020-02-18 10:25 ` 王文虎
1 sibling, 1 reply; 13+ messages in thread
From: Christophe Leroy @ 2020-01-21 8:37 UTC (permalink / raw)
To: 王文虎, Andrew Donnellan
Cc: Kate Stewart, Richard Fontana, Greg Kroah-Hartman, linux-kernel,
wangwenhu, Paul Mackerras, trivial, Thomas Gleixner,
linuxppc-dev, lonehugo
Le 21/01/2020 à 07:59, 王文虎 a écrit :
> 发件人：Andrew Donnellan <ajd@linux.ibm.com>
> 发送日期：2020-01-21 14:13:07
> 收件人：wangwenhu <wenhu.pku@gmail.com>,Benjamin Herrenschmidt <benh@kernel.crashing.org>,Paul Mackerras <paulus@samba.org>,Michael Ellerman <mpe@ellerman.id.au>,Kate Stewart <kstewart@linuxfoundation.org>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org
> 抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com
> 主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>>> From: wangwenhu <wenhu.wang@vivo.com>
>>>
>>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>>> fix the implicit declaration compile errors when building Cache-Sram.
>>>
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>> ^~~~~~~~~~~~~~~~
>>> bitmap_complement
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>> ^
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>> iounmap(cache_sram->base_virt);
>>> ^~~~~~~
>>> roundup
>>> cc1: all warnings being treated as errors
>>>
>>> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
>>
>> How long has this code been broken for?
>
> It's been broken almost 15 months since the commit below:
> "commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
> Author: Christophe Leroy <christophe.leroy@c-s.fr>
> Date: Tue Oct 9 13:51:41 2018 +0000
>
> powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."
>
> And we are working on it now for further development.
That's pretty surprising. That commit didn't change the iounmap(). It
only replaced ioremap_prot() by ioremap_coherent(). Both are defined in io.h
Christophe
>
>>
>>> ---
>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> index f6c665dac725..29b6868eff7d 100644
>>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>> @@ -17,6 +17,7 @@
>>> #include <linux/of_platform.h>
>>> #include <asm/pgtable.h>
>>> #include <asm/fsl_85xx_cache_sram.h>
>>> +#include <asm/io.h>
>>>
>>> #include "fsl_85xx_cache_ctlr.h"
>>>
>>
>> --
>> Andrew Donnellan OzLabs, ADL Canberra
>> ajd@linux.ibm.com IBM Australia Limited
>>
>
> Wenhu
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re:Re: [PATCH] powerpc/sysdev: fix compile errors
2020-01-21 8:37 ` Christophe Leroy
@ 2020-02-18 10:25 ` 王文虎
0 siblings, 0 replies; 13+ messages in thread
From: 王文虎 @ 2020-02-18 10:25 UTC (permalink / raw)
To: Christophe Leroy
Cc: Andrew Donnellan, Kate Stewart, Richard Fontana,
Greg Kroah-Hartman, linux-kernel, wangwenhu, Paul Mackerras,
trivial, Thomas Gleixner, linuxppc-dev, lonehugo
From: Christophe Leroy <christophe.leroy@c-s.fr>
Date: 2020-01-21 16:37:07
To:"王文虎" <wenhu.wang@vivo.com>,Andrew Donnellan <ajd@linux.ibm.com>
cc: Kate Stewart <kstewart@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,linux-kernel@vger.kernel.org,wangwenhu <wenhu.pku@gmail.com>,Paul Mackerras <paulus@samba.org>,trivial@kernel.org,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,lonehugo@hotmail.com
Subject: Re: [PATCH] powerpc/sysdev: fix compile errors>
>
>Le 21/01/2020 à 07:59, 王文虎 a écrit :
>> 发件人：Andrew Donnellan <ajd@linux.ibm.com>
>> 发送日期：2020-01-21 14:13:07
>> 收件人：wangwenhu <wenhu.pku@gmail.com>,Benjamin Herrenschmidt <benh@kernel.crashing.org>,Paul Mackerras <paulus@samba.org>,Michael Ellerman <mpe@ellerman.id.au>,Kate Stewart <kstewart@linuxfoundation.org>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,Richard Fontana <rfontana@redhat.com>,Thomas Gleixner <tglx@linutronix.de>,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org
>> 抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com
>> 主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>>>> From: wangwenhu <wenhu.wang@vivo.com>
>>>>
>>>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>>>> fix the implicit declaration compile errors when building Cache-Sram.
>>>>
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
>>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>> ^~~~~~~~~~~~~~~~
>>>> bitmap_complement
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>> ^
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
>>>> iounmap(cache_sram->base_virt);
>>>> ^~~~~~~
>>>> roundup
>>>> cc1: all warnings being treated as errors
>>>>
>>>> Signed-off-by: wangwenhu <wenhu.wang@vivo.com>
>>>
>>> How long has this code been broken for?
>>
>> It's been broken almost 15 months since the commit below:
>> "commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
>> Author: Christophe Leroy <christophe.leroy@c-s.fr>
>> Date: Tue Oct 9 13:51:41 2018 +0000
>>
>> powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."
>>
>> And we are working on it now for further development.
>
>That's pretty surprising. That commit didn't change the iounmap(). It
>only replaced ioremap_prot() by ioremap_coherent(). Both are defined in io.h
>
>Christophe
>
The compile error exists since the uploading of the driver
Details below:
1. "ioremap_flags" defined in "asm/io.h" was used primarily(Wed Oct 13 17:30:56 2010):
(6db92cc9d07d: powerpc/85xx: add cache-sram support);
2. "ioremap_prot" was used to replace "ioremap_flags"
(40f1ce7fb7e8: powerpc: Remove ioremap_flags);
3. "ioremap_coherent" was used to replace "ioremap_prot":
(aa91796ec463: powerpc: don't use ioremap_prot() nor __ioremap() unless really needed.)
So I will do the re-patch with a "Fixed" tag and "<linux/io.h>" include modification.
Which commit should be referenced to append to "Fixed" tag? (No.1 or No.3 ?)
Wenhu
>>
>>>
>>>> ---
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> index f6c665dac725..29b6868eff7d 100644
>>>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>>>> @@ -17,6 +17,7 @@
>>>> #include <linux/of_platform.h>
>>>> #include <asm/pgtable.h>
>>>> #include <asm/fsl_85xx_cache_sram.h>
>>>> +#include <asm/io.h>
>>>>
>>>> #include "fsl_85xx_cache_ctlr.h"
>>>>
>>>
>>> --
>>> Andrew Donnellan OzLabs, ADL Canberra
>>> ajd@linux.ibm.com IBM Australia Limited
>>>
>>
>> Wenhu
>>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-05-18 10:32 ` Jiri Kosina
2020-05-18 10:36 ` Christophe Leroy
@ 2020-05-18 11:37 ` Michael Ellerman
1 sibling, 0 replies; 13+ messages in thread
From: Michael Ellerman @ 2020-05-18 11:37 UTC (permalink / raw)
To: Jiri Kosina, Christophe Leroy
Cc: WANG Wenhu, Benjamin Herrenschmidt, Paul Mackerras, Kate Stewart,
Greg Kroah-Hartman, Allison Randal, Thomas Gleixner,
linuxppc-dev, linux-kernel, wenhu.pku
Jiri Kosina <jikos@kernel.org> writes:
> On Mon, 18 May 2020, Jiri Kosina wrote:
>> > > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
>> > > implicit-declaration compile errors when building Cache-Sram.
>> > >
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
>> > > ‘instantiate_cache_sram’:
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
>> > > of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’?
>> > > [-Werror=implicit-function-declaration]
>> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>> > > ^~~~~~~~~~~~~~~~
>> > > bitmap_complement
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
>> > > pointer from integer without a cast [-Werror=int-conversion]
>> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>> > > ^
>> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
>> > > of function ‘iounmap’; did you mean ‘roundup’?
>> > > [-Werror=implicit-function-declaration]
>> > > iounmap(cache_sram->base_virt);
>> > > ^~~~~~~
>> > > roundup
>> > > cc1: all warnings being treated as errors
>> > >
>> > > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>> > > Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
>> >
>> > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>
>> As this doesn't seem to have been picked up for linux-next yet, I am
>> picking it up now.
>
> Only now I've noticed that this is actually a dead code o_O as this file
> can't be built by any combination of config options. So I am dropping the
> patch again, but why do we keep it in the tree in the first place?
Yeah, sigh.
As Christophe pointed out, it has been dead code for a long time but
there is a series in flight that's trying to make it usable.
cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-05-18 10:32 ` Jiri Kosina
@ 2020-05-18 10:36 ` Christophe Leroy
2020-05-18 11:37 ` Michael Ellerman
1 sibling, 0 replies; 13+ messages in thread
From: Christophe Leroy @ 2020-05-18 10:36 UTC (permalink / raw)
To: Jiri Kosina, Christophe Leroy
Cc: WANG Wenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Allison Randal, Thomas Gleixner, linuxppc-dev, linux-kernel,
wenhu.pku
Le 18/05/2020 à 12:32, Jiri Kosina a écrit :
> On Mon, 18 May 2020, Jiri Kosina wrote:
>
>>>> Include linux/io.h into fsl_85xx_cache_sram.c to fix the
>>>> implicit-declaration compile errors when building Cache-Sram.
>>>>
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
>>>> ‘instantiate_cache_sram’:
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
>>>> of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’?
>>>> [-Werror=implicit-function-declaration]
>>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>> ^~~~~~~~~~~~~~~~
>>>> bitmap_complement
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
>>>> pointer from integer without a cast [-Werror=int-conversion]
>>>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>>> ^
>>>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
>>>> of function ‘iounmap’; did you mean ‘roundup’?
>>>> [-Werror=implicit-function-declaration]
>>>> iounmap(cache_sram->base_virt);
>>>> ^~~~~~~
>>>> roundup
>>>> cc1: all warnings being treated as errors
>>>>
>>>> Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
>>>> Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
>>>
>>> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>
>> As this doesn't seem to have been picked up for linux-next yet, I am
>> picking it up now.
>
> Only now I've noticed that this is actually a dead code o_O as this file
> can't be built by any combination of config options. So I am dropping the
> patch again, but why do we keep it in the tree in the first place?
>
There is a series aiming at making use of it, see
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=172421
Christophe
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-05-18 10:29 ` Jiri Kosina
@ 2020-05-18 10:32 ` Jiri Kosina
2020-05-18 10:36 ` Christophe Leroy
2020-05-18 11:37 ` Michael Ellerman
0 siblings, 2 replies; 13+ messages in thread
From: Jiri Kosina @ 2020-05-18 10:32 UTC (permalink / raw)
To: Christophe Leroy
Cc: WANG Wenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Allison Randal, Thomas Gleixner, linuxppc-dev, linux-kernel,
wenhu.pku
On Mon, 18 May 2020, Jiri Kosina wrote:
> > > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
> > > implicit-declaration compile errors when building Cache-Sram.
> > >
> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
> > > ‘instantiate_cache_sram’:
> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
> > > of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’?
> > > [-Werror=implicit-function-declaration]
> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > > ^~~~~~~~~~~~~~~~
> > > bitmap_complement
> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
> > > pointer from integer without a cast [-Werror=int-conversion]
> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > > ^
> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
> > > of function ‘iounmap’; did you mean ‘roundup’?
> > > [-Werror=implicit-function-declaration]
> > > iounmap(cache_sram->base_virt);
> > > ^~~~~~~
> > > roundup
> > > cc1: all warnings being treated as errors
> > >
> > > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> > > Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
> >
> > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> As this doesn't seem to have been picked up for linux-next yet, I am
> picking it up now.
Only now I've noticed that this is actually a dead code o_O as this file
can't be built by any combination of config options. So I am dropping the
patch again, but why do we keep it in the tree in the first place?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-03-02 6:38 ` Christophe Leroy
@ 2020-05-18 10:29 ` Jiri Kosina
2020-05-18 10:32 ` Jiri Kosina
0 siblings, 1 reply; 13+ messages in thread
From: Jiri Kosina @ 2020-05-18 10:29 UTC (permalink / raw)
To: Christophe Leroy
Cc: WANG Wenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Allison Randal, Thomas Gleixner, linuxppc-dev, linux-kernel,
wenhu.pku
On Mon, 2 Mar 2020, Christophe Leroy wrote:
> > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
> > implicit-declaration compile errors when building Cache-Sram.
> >
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
> > ‘instantiate_cache_sram’:
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
> > of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’?
> > [-Werror=implicit-function-declaration]
> > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > ^~~~~~~~~~~~~~~~
> > bitmap_complement
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
> > pointer from integer without a cast [-Werror=int-conversion]
> > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> > ^
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
> > of function ‘iounmap’; did you mean ‘roundup’?
> > [-Werror=implicit-function-declaration]
> > iounmap(cache_sram->base_virt);
> > ^~~~~~~
> > roundup
> > cc1: all warnings being treated as errors
> >
> > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> > Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
As this doesn't seem to have been picked up for linux-next yet, I am
picking it up now.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] powerpc/sysdev: fix compile errors
2020-03-02 5:37 WANG Wenhu
@ 2020-03-02 6:38 ` Christophe Leroy
2020-05-18 10:29 ` Jiri Kosina
0 siblings, 1 reply; 13+ messages in thread
From: Christophe Leroy @ 2020-03-02 6:38 UTC (permalink / raw)
To: WANG Wenhu, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, Kate Stewart, Greg Kroah-Hartman,
Allison Randal, Thomas Gleixner, linuxppc-dev, linux-kernel
Cc: wenhu.pku, trivial
Le 02/03/2020 à 06:37, WANG Wenhu a écrit :
> Include linux/io.h into fsl_85xx_cache_sram.c to fix the
> implicit-declaration compile errors when building Cache-Sram.
>
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> ^~~~~~~~~~~~~~~~
> bitmap_complement
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> ^
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
> iounmap(cache_sram->base_virt);
> ^~~~~~~
> roundup
> cc1: all warnings being treated as errors
>
> Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> index f6c665dac725..be3aef4229d7 100644
> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <asm/pgtable.h>
> #include <asm/fsl_85xx_cache_sram.h>
> +#include <linux/io.h>
>
> #include "fsl_85xx_cache_ctlr.h"
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] powerpc/sysdev: fix compile errors
@ 2020-03-02 5:37 WANG Wenhu
2020-03-02 6:38 ` Christophe Leroy
0 siblings, 1 reply; 13+ messages in thread
From: WANG Wenhu @ 2020-03-02 5:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Kate Stewart, Greg Kroah-Hartman, Allison Randal,
Thomas Gleixner, wangwenhu, linuxppc-dev, linux-kernel
Cc: trivial, wenhu.pku
Include linux/io.h into fsl_85xx_cache_sram.c to fix the
implicit-declaration compile errors when building Cache-Sram.
arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’:
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration]
cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
^~~~~~~~~~~~~~~~
bitmap_complement
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
^
arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration]
iounmap(cache_sram->base_virt);
^~~~~~~
roundup
cc1: all warnings being treated as errors
Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
---
arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
index f6c665dac725..be3aef4229d7 100644
--- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
+++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
@@ -17,6 +17,7 @@
#include <linux/of_platform.h>
#include <asm/pgtable.h>
#include <asm/fsl_85xx_cache_sram.h>
+#include <linux/io.h>
#include "fsl_85xx_cache_ctlr.h"
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-05-18 11:37 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 5:31 [PATCH] powerpc/sysdev: fix compile errors wangwenhu
2020-01-21 5:58 ` Christophe Leroy
2020-01-21 6:13 ` Andrew Donnellan
2020-01-21 6:59 ` 王文虎
2020-01-21 8:21 ` Christophe Leroy
2020-01-21 8:37 ` Christophe Leroy
2020-02-18 10:25 ` 王文虎
2020-03-02 5:37 WANG Wenhu
2020-03-02 6:38 ` Christophe Leroy
2020-05-18 10:29 ` Jiri Kosina
2020-05-18 10:32 ` Jiri Kosina
2020-05-18 10:36 ` Christophe Leroy
2020-05-18 11:37 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).