From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181AbdDQPNi (ORCPT ); Mon, 17 Apr 2017 11:13:38 -0400 Received: from mout.web.de ([212.227.17.12]:65110 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbdDQPNb (ORCPT ); Mon, 17 Apr 2017 11:13:31 -0400 Subject: [PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 17 Apr 2017 17:13:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:q4Nqwr7y0iOhXRZRGv5gHE9CNgwvnt4p4oFYxyC18E+sD8z2pB4 kSI/2VX34GLly33tYm/DioOIwxAVsycrGDR4ViWw9JWxioHpOisl6gVB/gteFBICs4ZSqa0 pTcZ2BhsflaavhuWeLHnVsgAH9aQGvL/mHRVp2O8eGieq+bW8FKGEDx9zGfSsFd9Qc6X9Np Dvl3qqaq0kbbKztJODzVw== X-UI-Out-Filterresults: notjunk:1;V01:K0:7tAvFLBvhU8=:wfx9nOyZCkeVqV8c5xX/Yk XMMOZSpAM5eoM3Ccl/HCemBxTLtrVrTDy4T45h50DUr2b3USg2vOSTnKE5BwDYr5EFYI75E8N aZGLAkol8JnWqtpUmOoyDSMkBxPePWQ7VVupuB8H+Y+c0PL9DCOdjMZtpdw5K/iwwf5BwLhNM KzRlVCKrpvSM4LIhkAhM7pRi4/Scek5/XMYbXobKT9YJDOGI8Z6fQTOe79MCrJhxSdlbnJAee aj0+sXLVAUwzQiJ/CckGSyiLAlabaLKuAONRdaTFLf8TnfGeGCFBJxX1cZgVpyvzlnIYp5H/e cY6w3t3E3IU9eIj74W6r2Fe9LlcIcAme21GtBEHJ/RQ2Ztn/ZKKyzjO3SK8S9in+X70j42UID jCKiikyYHYZm4ICHAF/ftbMgWhhWiRHKoKscvEr1Upi+GDUSXWPTbjnS/E+a7Ma1OT+2aX5PC 4QXe1xudNvK2899+q1ozY4BvLTFmJptoFEmXdK73Kn/7ieq9L+3F3TaAoU1ZZ49g9KesVaYCR DXvinnuocdTWgL8J3TrjDJJzqp2s7PsuVHWDUZay1SSnCKwCZnz6JD+p6t0I1x5OkkHXVdpjP iheko346TUEjeZfa8DaP34WOFielMUMeEl4a2xWq7HQsJu6s8Pgs7Ay+MS2+SZ7FBi2+ijWth Kl+4+So4b24lBy6zLkdDFR6Gyeh15CsQAGpEPA/6A6bpC9zehkR0JVh0rgOI3ZKV49pumgyWl 6fh0BVMIqvJjyeja1iZqq+LqXtComp/Ahr8IsSiBx7rqby0k5y1mImPFcCGG6R2MelUxbHLpS 6Y0vYwO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 16 Apr 2017 22:11:22 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvneta.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 9c9eed5a8e28..9c2ddd22a86f 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2933,7 +2933,8 @@ static int mvneta_txq_init(struct mvneta_port *pp, mvreg_write(pp, MVNETA_TXQ_BASE_ADDR_REG(txq->id), txq->descs_phys); mvreg_write(pp, MVNETA_TXQ_SIZE_REG(txq->id), txq->size); - txq->tx_skb = kmalloc(txq->size * sizeof(*txq->tx_skb), GFP_KERNEL); + txq->tx_skb = kmalloc_array(txq->size, sizeof(*txq->tx_skb), + GFP_KERNEL); if (txq->tx_skb == NULL) { dma_free_coherent(pp->dev->dev.parent, txq->size * MVNETA_DESC_ALIGNED_SIZE, -- 2.12.2