From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5B5C43460 for ; Fri, 21 May 2021 01:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F1F86138C for ; Fri, 21 May 2021 01:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237937AbhEUB4k (ORCPT ); Thu, 20 May 2021 21:56:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237897AbhEUB4h (ORCPT ); Thu, 20 May 2021 21:56:37 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26EA6C061763 for ; Thu, 20 May 2021 18:55:14 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id i19so7790398qtw.9 for ; Thu, 20 May 2021 18:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fwiHAMDwaEBdHTRR64T2XvPf2rYlFu2icAvRI/d7T1I=; b=zMWi9VKDjUCoAvJ0fA7qzIu2MsoWVDeBz+toiOHCCNEYl9SRV1zn+HZZnTQlJBI6G3 H9x8R3l+HXuAVaMlhZZOh8aYmsb/QychwpkNJ+rT/plAh//NKnTiwZ4JrG0EqT8Nrw3W 5qhCILVe2T1zUGo3IqVLQ+YcnvzOCmmirl4TsX40HxjFf/qDMGA9pJQYGtne6ew+KnOv CfS79JurOQmmwHJ+WkkI40L4kRXC5mPgHY+rChSCAtOfir1ftsFCfRi2wYoHitQGbIAY 5seRnAFc6wpT2/LSFXcCYq8DAnzEkA8iYJbIIDFDwarUSpt5GQiO0oC5mGaN6Ob5rWRF wopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fwiHAMDwaEBdHTRR64T2XvPf2rYlFu2icAvRI/d7T1I=; b=cl5hyt0j03j0NuJszisQznaowElvrjruXlWXnu6ZCG/W0hCzIDQ+DTpicqeqpqEJLv 71JGd6VT0RebUA28oLNqOXhK2vMwTUip9Wt0KNHqYOUMHQ/BSfaO3yge01+2waAko56R tGEi1t0Lbs6MSfJ5jYOdefE+JZ2JtIWThoT42xPC/RUBwmt2PbOe7P8DKAnT6UFNICzZ n8l93wX1PyiPKoR8jOWSWJeu0VsHZ2ZPG3dP+GIRRGeBrgHBy2M2MKm9P4Fwvkon/Tk/ GuIPyvjzfte3a0A8py3xTc4w7NCH8Zb/BDqUoXTN6zF0nTpt4xsda1J1vVXgxvTJjGKj WZIQ== X-Gm-Message-State: AOAM532qUuPfSK6W/wExX7RqWbpQu/BpzDVa5oXKUEJKkWo8F7JW6OOf vC6nj0dZ8B0KV5JNM/NxrM6A2w== X-Google-Smtp-Source: ABdhPJwaD9dTnZOk7H0JrFBWu4neTsWggW+sHCNqzVuNjKTsqrhNsiGX410biNoVKSQrHvE+ZvvSeA== X-Received: by 2002:ac8:7d0c:: with SMTP id g12mr8974906qtb.224.1621562113144; Thu, 20 May 2021 18:55:13 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id t6sm3725006qkh.117.2021.05.20.18.55.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 18:55:12 -0700 (PDT) Subject: Re: [PATCH v3 14/17] crypto: qce: Print a failure msg in case probe() fails To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org Cc: Bjorn Andersson , Rob Herring , Andy Gross , Herbert Xu , "David S . Miller" , Stephen Boyd , Michael Turquette , Vinod Koul , dmaengine@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com References: <20210519143700.27392-1-bhupesh.sharma@linaro.org> <20210519143700.27392-15-bhupesh.sharma@linaro.org> From: Thara Gopinath Message-ID: Date: Thu, 20 May 2021 21:55:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210519143700.27392-15-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/21 10:36 AM, Bhupesh Sharma wrote: > Print a failure message (dev_err) in case the qcom qce crypto > driver probe() fails. > > Cc: Thara Gopinath > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: Andy Gross > Cc: Herbert Xu > Cc: David S. Miller > Cc: Stephen Boyd > Cc: Michael Turquette > Cc: Vinod Koul > Cc: dmaengine@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma I kind of felt you can club patch 14 and 15. But it is upto you.. FWIW, Reviewed-by: Thara Gopinath Warm Regards Thara > --- > drivers/crypto/qce/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 8c3c68ba579e..aecb2cdd79e5 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -300,6 +300,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > err_clks_core: > clk_disable_unprepare(qce->core); > err_out: > + dev_err(dev, "%s failed : %d\n", __func__, ret); > return ret; > } > >