From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754194AbdFWDtA (ORCPT ); Thu, 22 Jun 2017 23:49:00 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8780 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035AbdFWDs6 (ORCPT ); Thu, 22 Jun 2017 23:48:58 -0400 Subject: Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback To: Andrew Lunn CC: , , , , , , , , , , , , , References: <1498121613-64572-1-git-send-email-linyunsheng@huawei.com> <20170623032011.GB5432@lunn.ch> From: Yunsheng Lin Message-ID: Date: Fri, 23 Jun 2017 11:48:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170623032011.GB5432@lunn.ch> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.190.125] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.594C8F99.0094,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3e8562bcddac8329ef0b4775c557eea9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, Andrew On 2017/6/23 11:20, Andrew Lunn wrote: > On Thu, Jun 22, 2017 at 04:53:33PM +0800, Lin Yun Sheng wrote: >> Use function set_loopback in phy_driver to setup phy loopback >> when doing ethtool self test. >> >> Signed-off-by: Lin Yun Sheng >> --- >> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 64 ++++-------------------- >> 1 file changed, 10 insertions(+), 54 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> index e95795b..660b51e 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> @@ -259,66 +259,22 @@ static int hns_nic_set_link_ksettings(struct net_device *net_dev, >> >> static int hns_nic_config_phy_loopback(struct phy_device *phy_dev, u8 en) >> { >> -#define COPPER_CONTROL_REG 0 >> -#define PHY_POWER_DOWN BIT(11) >> -#define PHY_LOOP_BACK BIT(14) >> - u16 val = 0; >> >> - if (phy_dev->is_c45) /* c45 branch adding for XGE PHY */ >> + if (phy_dev->is_c45 || !phy_dev->drv) >> + return -ENOTSUPP; >> + >> + if (!phy_dev->drv->resume || !phy_dev->drv->suspend || >> + !phy_dev->drv->set_loopback) >> return -ENOTSUPP; > > No, i said to have a function is phy.c which does this check. The phy > core needs to keep track of if loopback is already enabled, and return > an error if it is attempted to turn it on twice, or disable it when it > is not enabled. what should the Mac driver do when it receive the error? I assume that it will return it to userspace. because the rtnl_lock ensure only one ethtool is executing, if the function return error, it means some bug in the mac driver, am I right? will add the function in phy.c next version. Best Regards Yunsheng Lin