From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcFKQuZ (ORCPT ); Sat, 11 Jun 2016 12:50:25 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:52408 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbcFKQuY (ORCPT ); Sat, 11 Jun 2016 12:50:24 -0400 Subject: Re: [PATCH v2] staging: iio: ad5933: fix order of cycle conditions To: Luis de Bethencourt , linux-kernel@vger.kernel.org References: <1464809154-14868-1-git-send-email-luisbg@osg.samsung.com> Cc: gregkh@linuxfoundation.org, lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org From: Jonathan Cameron Message-ID: Date: Sat, 11 Jun 2016 17:50:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464809154-14868-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/16 20:25, Luis de Bethencourt wrote: > Correctly handle the settling time cycles value. The else branch is an > impossible condition, > 1022 in the else branch of > 511. Flipping the order. > > Based on the Table 13 at the bottom of Page 25 of the Data Sheet: > http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf > > Signed-off-by: Luis de Bethencourt > Reviewed-by: Lars-Peter Clausen While Lars did review, it I'm not seeing an email where he gave this tag (my inbox may well have eaten it). Lars, could you confirm that you are happy with the patch as it now stands. Certainly looks right to me! Thanks, Jonathan > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > index 9f43976..170ac98 100644 > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > @@ -444,10 +444,10 @@ static ssize_t ad5933_store(struct device *dev, > st->settling_cycles = val; > > /* 2x, 4x handling, see datasheet */ > - if (val > 511) > - val = (val >> 1) | (1 << 9); > - else if (val > 1022) > + if (val > 1022) > val = (val >> 2) | (3 << 9); > + else if (val > 511) > + val = (val >> 1) | (1 << 9); > > dat = cpu_to_be16(val); > ret = ad5933_i2c_write(st->client, >