From: Marc Zyngier <marc.zyngier@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>, Christoph Hellwig <hch@lst.de>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI/msi: remove unused function pci_msi_create_default_irq_domain
Date: Thu, 9 Feb 2017 08:53:14 +0000 [thread overview]
Message-ID: <d43182fa-fedb-c648-f607-a7aa11e6f753@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702081441100.3536@nanos>
On 08/02/17 13:43, Thomas Gleixner wrote:
> On Fri, 3 Feb 2017, Christoph Hellwig wrote:
>
> No objections, but then we also can remove:
>
> struct irq_domain * __weak arch_get_pci_msi_domain(struct pci_dev *dev)
>
> as there are no arch specific implementations
>
> along with:
>
> static struct irq_domain *pci_msi_default_domain;
>
> because pci_msi_create_default_irq_domain() is the only place where the
> default domain is ever set.
Indeed. I'm all for dropping the "default" stuff, as it only gives
people the idea that they can get away with it (most of the time, they
cannot).
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-02-09 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 16:27 two small PCI MSI cleanups Christoph Hellwig
2017-02-03 16:27 ` [PATCH 1/2] PCI/msi: remove unused function pci_msi_create_default_irq_domain Christoph Hellwig
2017-02-08 13:43 ` Thomas Gleixner
2017-02-09 8:53 ` Marc Zyngier [this message]
2017-02-03 16:27 ` [PATCH 2/2] PCI/msi: remove pci_msi_domain_{alloc,free}_irqs Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d43182fa-fedb-c648-f607-a7aa11e6f753@arm.com \
--to=marc.zyngier@arm.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).