From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Quentin Schulz <quentin.schulz@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read
Date: Wed, 17 Oct 2018 17:37:47 +0200 [thread overview]
Message-ID: <d4347a46-ff54-3b02-97b7-58ad7017c2c0@embeddedor.com> (raw)
In-Reply-To: <93008479-9e81-1d27-bd31-0cff75c4dd12@ti.com>
Hi Kishon,
On 10/16/18 10:48 AM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 16 October 2018 02:16 PM, Gustavo A. R. Silva wrote:
>> Hi,
>>
>> On 10/9/18 9:28 AM, Quentin Schulz wrote:
>>> Hi Gustavo,
>>>
>>> On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
>>>> Currently, there is an out-of-bounds read on array ctrl->phys,
>>>> once variable i reaches the maximum array size of SERDES_MAX
>>>> in the for loop.
>>>>
>>>> Fix this by changing the condition in the for loop from
>>>> i <= SERDES_MAX to i < SERDES_MAX.
>>>>
>>>
>>> Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
>>>
>>
>> Friendly ping. Who can you take this?
>
> This can go during the 4.20 -rc cycle.
>
Should I resend the following patch to you, so the whole series is
applied to your phy tree?
https://lore.kernel.org/patchwork/patch/997326/
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-10-17 16:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 22:20 [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Gustavo A. R. Silva
2018-10-08 22:21 ` [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 Gustavo A. R. Silva
2018-10-09 7:27 ` Quentin Schulz
2018-10-16 8:44 ` Gustavo A. R. Silva
2018-10-17 15:09 ` Rob Herring
2018-10-17 15:19 ` Gustavo A. R. Silva
2018-10-17 15:23 ` Rob Herring
2018-10-17 15:45 ` Gustavo A. R. Silva
2018-10-08 22:22 ` [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read Gustavo A. R. Silva
2018-10-09 7:28 ` Quentin Schulz
2018-10-16 8:46 ` Gustavo A. R. Silva
2018-10-16 8:48 ` Kishon Vijay Abraham I
2018-10-17 15:37 ` Gustavo A. R. Silva [this message]
2018-11-12 8:27 ` Kishon Vijay Abraham I
2018-10-09 7:28 ` [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Quentin Schulz
2018-10-09 14:13 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4347a46-ff54-3b02-97b7-58ad7017c2c0@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.schulz@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).