From: linmiaohe <linmiaohe@huawei.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"decui@microsoft.com" <decui@microsoft.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
"jeremy@azazel.net" <jeremy@azazel.net>,
"mashirle@us.ibm.com" <mashirle@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] net: Fix potential deadloop in skb_copy_ubufs()
Date: Sat, 15 Aug 2020 02:18:09 +0000 [thread overview]
Message-ID: <d4390fcd400a4dc2b8f2a61b9190155f@huawei.com> (raw)
Eric Dumazet <edumazet@google.com> wrote:
>On Fri, Aug 14, 2020 at 12:14 AM linmiaohe <linmiaohe@huawei.com> wrote:
>>
>> Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>>
>> Since we always call skb_orphan_frags in skb_clone, is it unnecessary to call skb_orphan_frags in pskb_expand_head when skb is cloned ?
>
>Please give us a real case.
>
>I fear that your patches are coming directly from some kind of automated tool, that really misses how the code is really used from _current_ code base, not _hypothetical_ one.
>
>This is very time consuming. Please provide evidence first.
>
>Thank you.
I'am sorry about it. I do this mainly through code review and do some test code. So the problem codepath may not exist from current code base, but may
happen when we do not take care of it in the future use. We may forget same assumption. And make these assumptions clear seems not a bad thing.
But I'am going to just drop this patch. I believe you all can handle the things correctly.
Many thanks.
next reply other threads:[~2020-08-16 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 2:18 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-14 7:14 [PATCH 1/5] net: Fix potential deadloop in skb_copy_ubufs() linmiaohe
2020-08-14 15:14 ` Eric Dumazet
2020-08-07 9:48 linmiaohe
2020-08-06 11:50 linmiaohe
2020-08-06 12:25 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4390fcd400a4dc2b8f2a61b9190155f@huawei.com \
--to=linmiaohe@huawei.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jakub@cloudflare.com \
--cc=jeremy@azazel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mashirle@us.ibm.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=rdunlap@infradead.org \
--cc=steffen.klassert@secunet.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).