From: Scott Wood <oss@buserror.net>
To: andy.tang@nxp.com, sboyd@kernel.org, mturquette@baylibre.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3 v2] clk: qoriq: update clock driver
Date: Wed, 24 Oct 2018 13:37:28 -0500 [thread overview]
Message-ID: <d4598171243a37516faae71095eb3126d77fa723.camel@buserror.net> (raw)
In-Reply-To: <20181024021122.3942-3-andy.tang@nxp.com>
On Wed, 2018-10-24 at 10:11 +0800, andy.tang@nxp.com wrote:
> From: Yuantian Tang <andy.tang@nxp.com>
>
> Legacy bindings are deleted. So the legacy support in driver
> can be deleted safely.
NACK (both this and 2/3). The legacy support is intended to preserve
compatibility, regardless of what the dts files in the current kernel tree do.
If years later we find it's been broken for a while and nobody complained,
then maybe it'll be time to remove it, but why deliberately throw away
compatibility the instant the users have been removed from reference DTs that
might be copied by board vendors, etc?
Note that even if we didn't care about long-term compatibility at all,
removing the support in the same patchset as the change to the dts files means
that the patches can't go in via separate trees (though if that's still the
intent, you should make it clear who you're asking to take what by putting
them in separate patchsets).
-Scott
next prev parent reply other threads:[~2018-10-24 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 2:11 [PATCH 1/3 v2] powerpc/fsl: Use new clockgen binding andy.tang
2018-10-24 2:11 ` [PATCH 2/3 v2] clk: qoriq: remove legacy bindings and add more compatibles andy.tang
2018-10-24 2:11 ` [PATCH 3/3 v2] clk: qoriq: update clock driver andy.tang
2018-10-24 18:37 ` Scott Wood [this message]
2018-10-25 2:40 ` Andy Tang
2018-10-24 22:10 ` [PATCH 2/3 v2] clk: qoriq: remove legacy bindings and add more compatibles Rob Herring
2018-10-25 2:41 ` Andy Tang
2018-10-24 17:41 ` [PATCH 1/3 v2] powerpc/fsl: Use new clockgen binding Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4598171243a37516faae71095eb3126d77fa723.camel@buserror.net \
--to=oss@buserror.net \
--cc=andy.tang@nxp.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=mturquette@baylibre.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).