From: Swapnil Sapkal <Swapnil.Sapkal@amd.com>
To: Doug Smythies <dsmythies@telus.net>,
'Mario Limonciello' <mario.limonciello@amd.com>
Cc: rafael.j.wysocki@intel.com, Ray.Huang@amd.com, li.meng@amd.com,
shuah@kernel.org, sukrut.bellary@gmail.com,
gautham.shenoy@amd.com, wyes.karny@amd.com, Perry.Yuan@amd.com,
zwisler@chromium.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot
Date: Tue, 19 Sep 2023 13:06:39 +0530 [thread overview]
Message-ID: <d4635a1b-2a50-5858-62f0-c58f5b59b0a2@amd.com> (raw)
In-Reply-To: <001c01d9e9b0$073fadf0$15bf09d0$@telus.net>
Hello Doug,
Sorry for delay in response.
On 9/18/2023 3:13 AM, Doug Smythies wrote:
> On 2023.09.17 15:17 Doug wrote:
>> On Fri, Sep 15, 2023 at 2:31 PM Mario Limonciello
>>> On 9/15/2023 16:15, Doug Smythies wrote:
>>>> On 2023.09.15 03:41 Swapnil Sapkal wrote:
> ...
>>>> Not really related, but for a few years now I have been meaning to
>>>> change the minimum python version prerequisite to >= 3.0 and
>>>> to change the shebang line.
> ...
>>> Besides the shebang, you should also
>>> use a helper like 2to3 to look for any other changes.
>
> Hi Mario,
>
> I was not aware of the 2to3 helper.
> Thank you mentioning it.
> The 2to3 helper only changed one line,
> which I included in the minimum python version
> patch I just submitted.
>
I tried with installing python3-gnuplot and it worked for me. Initially I
tried with other packages in prerequisites and it didn't worked for me.
I will send v2 removing this patch.
>> I already did the python 3 patch in January, 2020:
>> commit e749e09db30c38f1a275945814b0109e530a07b0
>> tools/power/x86/intel_pstate_tracer: changes for python 3 compatibility
>>
>> I haven't had any issues since, shebang aside.
>
> ... Doug
>
>
--
Thanks and Regards,
Swapnil
prev parent reply other threads:[~2023-09-19 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 10:40 [PATCH 0/2] Fix issues observed with selftests/amd-pstate Swapnil Sapkal
2023-09-15 10:40 ` [PATCH 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut Swapnil Sapkal
2023-09-15 10:40 ` [PATCH 2/2] tools/power/x86/intel_pstate_tracer: Use pygnuplot package for Gnuplot Swapnil Sapkal
2023-09-15 21:15 ` Doug Smythies
2023-09-15 21:31 ` Mario Limonciello
2023-09-15 22:16 ` Doug Smythies
2023-09-17 21:43 ` Doug Smythies
2023-09-19 7:36 ` Swapnil Sapkal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4635a1b-2a50-5858-62f0-c58f5b59b0a2@amd.com \
--to=swapnil.sapkal@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Ray.Huang@amd.com \
--cc=dsmythies@telus.net \
--cc=gautham.shenoy@amd.com \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=shuah@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sukrut.bellary@gmail.com \
--cc=wyes.karny@amd.com \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).