From: cang@codeaurora.org
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH v1 1/6] scsi: ufs: Add device reset in link recovery path
Date: Mon, 04 Nov 2019 08:59:11 +0800 [thread overview]
Message-ID: <d46aa74f8623cc0b61b94bd4fcc25ce4@codeaurora.org> (raw)
In-Reply-To: <BN7PR08MB56845B4A5F206A319CAFD3B1DB7C0@BN7PR08MB5684.namprd08.prod.outlook.com>
On 2019-11-04 05:48, Bean Huo (beanhuo) wrote:
> Hi, Can Guo
>
>> In order to recover from hibern8 exit failure, perform a reset in link
>> recovery
>> path before issuing link start-up.
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> ---
>> drivers/scsi/ufs/ufshcd.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index
>> c28c144..525f8e6 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -3859,6 +3859,9 @@ static int ufshcd_link_recovery(struct ufs_hba
>> *hba)
>> ufshcd_set_eh_in_progress(hba);
>> spin_unlock_irqrestore(hba->host->host_lock, flags);
>>
>> + /* Reset the attached device */
>> + ufshcd_vops_device_reset(hba);
>> +
>> ret = ufshcd_host_reset_and_restore(hba);
>>
> There is time consumption in reset, It is true that reset can
> hide/solve some issues.
> I don't know if you experienced issue resulting from an absent reset
> in this case mentioned in
> Patch commit comment.
>
Hi Bean,
Yes, we did see some issues without this device reset here. For example,
link start-up failure and/or NOP-IN timeout during probe stage.
Best regards,
Can Guo.
>> spin_lock_irqsave(hba->host->host_lock, flags);
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-11-04 0:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1572671016-883-1-git-send-email-cang@codeaurora.org>
2019-11-02 5:03 ` [PATCH v1 1/6] scsi: ufs: Add device reset in link recovery path Can Guo
2019-11-03 21:48 ` [EXT] " Bean Huo (beanhuo)
2019-11-04 0:59 ` cang [this message]
2019-11-02 5:03 ` [PATCH v1 2/6] scsi: ufs-qcom: Add reset control support for host controller Can Guo
2019-11-02 5:03 ` [PATCH v1 3/6] scsi: ufs: Fix up auto hibern8 enablement Can Guo
2019-11-02 5:03 ` [PATCH v1 4/6] scsi: ufs: Fix irq return code Can Guo
2019-11-02 5:03 ` [PATCH v1 5/6] scsi: ufs: Abort gating if clock on request is pending Can Guo
2019-11-02 5:03 ` [PATCH v1 6/6] scsi: ufs: Fix error handing during hibern8 enter Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46aa74f8623cc0b61b94bd4fcc25ce4@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).