From: Valentin Schneider <valentin.schneider@arm.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Alexey Dobriyan' <adobriyan@gmail.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"aarcange@redhat.com" <aarcange@redhat.com>
Subject: Re: [PATCH] sched: make struct task_struct::state 32-bit
Date: Wed, 4 Sep 2019 11:25:14 +0100 [thread overview]
Message-ID: <d46b479b-247b-a291-75f9-b60dd7114440@arm.com> (raw)
In-Reply-To: <651c419e45e043e9be8d0877b5a5406d@AcuMS.aculab.com>
On 04/09/2019 10:43, David Laight wrote:
> From: Alexey Dobriyan
>> Sent: 03 September 2019 19:19
> ...
>>> How did you come up with this changeset, did you pickaxe for some regexp?
>>
>> No, manually, backtracking up to the call chain.
>> Maybe I missed a few places.
>
> Renaming the structure field and getting the compiler to find all the uses can help.
>
> David
>
It's a good idea but sadly doesn't cover whatever the config doesn't
compile. A safer starting point could be
---
@state_var@
struct task_struct *p;
identifier var;
@@
(
var = p->state
|
p->state = var
)
@@
identifier state_var.var;
@@
- var
+ FIXME
---
But I'm hoping we can get something even better from coccinelle, stay
tuned...
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
prev parent reply other threads:[~2019-09-04 10:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 21:05 [PATCH] sched: make struct task_struct::state 32-bit Alexey Dobriyan
2019-09-02 23:02 ` Valentin Schneider
2019-09-03 16:23 ` Alexey Dobriyan
2019-09-03 16:31 ` Valentin Schneider
2019-09-03 6:51 ` [dm-devel] " Christoph Hellwig
2019-09-03 7:13 ` Peter Zijlstra
2019-09-03 17:29 ` Valentin Schneider
2019-09-03 18:19 ` Alexey Dobriyan
2019-09-03 21:51 ` Valentin Schneider
2019-09-04 12:07 ` Valentin Schneider
2019-09-04 17:48 ` Valentin Schneider
2019-09-05 15:51 ` Markus Elfring
2019-09-05 16:52 ` Valentin Schneider
2019-09-23 10:26 ` Valentin Schneider
2019-09-23 10:34 ` Julia Lawall
2019-09-23 11:26 ` Valentin Schneider
2019-09-23 11:43 ` Julia Lawall
2019-09-23 13:23 ` Valentin Schneider
2019-09-24 8:28 ` Markus Elfring
2019-09-24 8:07 ` Markus Elfring
2019-09-04 9:43 ` [PATCH] " David Laight
2019-09-04 10:25 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46b479b-247b-a291-75f9-b60dd7114440@arm.com \
--to=valentin.schneider@arm.com \
--cc=David.Laight@ACULAB.COM \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).