From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: zhanglianjie <zhanglianjie@uniontech.com>,
jiaxun.yang@flygoat.com, chenhuacai@kernel.org,
tsbogend@alpha.franken.de
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: Fix the problem of mips architecture Oops
Date: Mon, 28 Jun 2021 11:51:02 +0300 [thread overview]
Message-ID: <d49404ca-b55c-847d-968d-273ca604b1e6@gmail.com> (raw)
In-Reply-To: <20210628054738.10964-1-zhanglianjie@uniontech.com>
Hello!
On 28.06.2021 8:47, zhanglianjie wrote:
> The cause of the problem is as follows:
> 1. when cat /sys/devices/system/memory/memory0/valid_zones,
> test_pages_in_a_zone() will be called.
> 2. test_pages_in_a_zone() finds the zone according to stat_pfn = 0.
> The smallest pfn of the numa node in the mips architecture is 128,
> and the page corresponding to the previous 0~127 pfn is not
> initialized (page->flags is 0xFFFFFFFF)
> 3. The nid and zonenum obtained using page_zone(pfn_to_page(0)) are out
> of bounds in the corresponding array,
> &NODE_DATA(page_to_nid(page))->node_zones[page_zonenum(page)],
> access to the out-of-bounds zone member variables appear abnormal,
> resulting in Oops.
> Therefore, it is necessary to keep the page between 0 and the minimum
> pfn to prevent Oops from appearing.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> ---
> arch/mips/loongson64/numa.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c
> index fa9b4a487a47..dba9e6f17b9e 100644
> --- a/arch/mips/loongson64/numa.c
> +++ b/arch/mips/loongson64/numa.c
> @@ -129,6 +129,9 @@ static void __init node_mem_init(unsigned int node)
> if (node_end_pfn(0) >= (0xffffffff >> PAGE_SHIFT))
> memblock_reserve((node_addrspace_offset | 0xfe000000),
> 32 << 20);
> +
> + /* Reserver pfn range 0~node[0]->node_start_pfn */
Reserve?
> + memblock_reserve(0, PAGE_SIZE * start_pfn);
> }
> }
[...]
MBR, Sergei
next prev parent reply other threads:[~2021-06-28 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 5:47 [PATCH v2] mm: Fix the problem of mips architecture Oops zhanglianjie
2021-06-28 8:51 ` Sergei Shtylyov [this message]
2021-06-28 9:05 ` zhanglianjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d49404ca-b55c-847d-968d-273ca604b1e6@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).