From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19271C433E0 for ; Wed, 30 Dec 2020 16:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0EF520780 for ; Wed, 30 Dec 2020 16:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbgL3QS2 (ORCPT ); Wed, 30 Dec 2020 11:18:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgL3QS1 (ORCPT ); Wed, 30 Dec 2020 11:18:27 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30390C061799; Wed, 30 Dec 2020 08:17:47 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id j12so15729961ota.7; Wed, 30 Dec 2020 08:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/uyDAirA8VQF0NgEtEzY/g6VOAomyBDYEreP48L36/U=; b=LNpQJtKMoVXT5ruUI7JOW34a3e3aQQbF+x4m+8uNOPLTojjJqUe8yCkoWWuB/ZYrJc gz+z0rqEIxsl0qjIf3nW40HxsIiPlB0Tjl/GvXHtJGU7sgErhV1xkl5aTtPZFGoSNlzh g71YPzmZ0c2h/ramJMEi90Yv5WdkBId2IlC/TkifoUHDowX3GEy/kq05vMOXe18RTTRI tX+8D5+E0O1y+UO8g2fcZ6Yt9fdCW5R7pUl+r3Urb+N9tO86PynAMxs+FXjMXA/P1oyP r+BJPJeRMlaCSFGwblwV4DmIQzp94AN18a+mW9eQjiliW0dJz5/e2kD5eNlgF/RAxdB+ mwMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/uyDAirA8VQF0NgEtEzY/g6VOAomyBDYEreP48L36/U=; b=cw9Xo7NuMyfdlgVFXSYm4VV/KBzOEQATBlZtLDZshQCjvwTy7KtgIkRZ0hjqiMBY9N G0PH75PrcXscFtTyjXnn1+ZGB5a/+tUAF2to+k8kAFmWOATyQ9hYu3cBSN3TkwmByAaL Whn+TBRM8Z/X5vPlWBlxpkXrmUGe/8XR/QX0dOGR04tB90W4UqoYevlLz9Ze1bRVhW0N +q8Yzx60U4FEfjtQm4z0LOZWIctW4bOEohNmqALoIa3etOIPgNekkWlUMPaygqhc19rl sWppvhlJ5VvJ242H2rpxp1VRvfQjrcGTv2i7iVhQlbAMejMCyLjA7ibP7Vcf9dDBrWqf c5Vg== X-Gm-Message-State: AOAM533SZ9Ns4lMEgNCYN52gwPZ4W+1n2PCYJLdzNhMHZPHADiDUWCSC oRhw5OfItMXZDuZmXAON3Rs= X-Google-Smtp-Source: ABdhPJxTWTUHFZ/ye4izRj5y9293jlqIoBwJHiN+BORC/n3kriEXbz7q74OICZAGaTC7HEFSrCf61g== X-Received: by 2002:a9d:6a1:: with SMTP id 30mr39303512otx.242.1609345066632; Wed, 30 Dec 2020 08:17:46 -0800 (PST) Received: from ?IPv6:2600:1700:dfe0:49f0:549a:788d:4851:c1b0? ([2600:1700:dfe0:49f0:549a:788d:4851:c1b0]) by smtp.gmail.com with ESMTPSA id c18sm10404458oib.31.2020.12.30.08.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Dec 2020 08:17:45 -0800 (PST) Subject: Re: Registering IRQ for MT7530 internal PHYs To: Andrew Lunn , DENG Qingfang Cc: "David S. Miller" , Heiner Kallweit , Jakub Kicinski , Landen Chao , Marc Zyngier , Matthias Brugger , Philipp Zabel , Russell King , Sean Wang , Thomas Gleixner , Vivien Didelot , Vladimir Oltean , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Weijie Gao , Chuanhong Guo , Linus Walleij , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= References: <20201230042208.8997-1-dqfext@gmail.com> From: Florian Fainelli Message-ID: Date: Wed, 30 Dec 2020 08:17:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/30/2020 7:16 AM, Andrew Lunn wrote: >> 2. Allocated ds->slave_mii_bus before calling ds->ops->setup, because >> we cannot call dsa_slave_mii_bus_init which is private. >> >> Any better ideas? > > Do what mv88e6xxx does, allocate the MDIO bus inside the switch > driver. Yes, exactly, or you could add additional hooks to allow intercepting the initialization and de-initialization of the ds->slave_mii_bus, something like this: https://github.com/ffainelli/linux/commit/758da087a819cd1a284de074ea7d8eae9f875f0b which was part of a larger series adding threaded IRQ support to the b53 driver: https://github.com/ffainelli/linux/commits/b53-irq -- Florian