From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771AbdGUWQr (ORCPT ); Fri, 21 Jul 2017 18:16:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44198 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdGUWQq (ORCPT ); Fri, 21 Jul 2017 18:16:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1A2D1C0587C7 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1A2D1C0587C7 Subject: Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool To: Lee Jones Cc: linux-kernel@vger.kernel.org References: <20170623082940.24917-1-hdegoede@redhat.com> <20170717110415.ecavjnwcjwkd4a4b@dell> From: Hans de Goede Message-ID: Date: Sat, 22 Jul 2017 00:16:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170717110415.ecavjnwcjwkd4a4b@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 21 Jul 2017 22:16:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 17-07-17 13:04, Lee Jones wrote: > On Fri, 23 Jun 2017, Hans de Goede wrote: > >> The PMIC provides ACPI OpRegions which must be available for other >> drivers' PS0 / PS3 methods early-on as such it must be builtin as the >> Kconfig help text already states. >> >> Somehow its Kconfig option ended up being a tristate though, this fixes >> this. >> >> Signed-off-by: Hans de Goede >> --- >> Note, feel free to squash this in the original commit if you wish > > Looks like the original commit is yet to be accepted. The original commit is already in Linus' tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mfd?id=de85d79f4aab67fe0537dd6e2c5d545b88239cc4 Regards, Hans > > Please ensure it's squashed in and resubmit. > >> --- >> drivers/mfd/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 8533cb46a875..be962d128f31 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC >> on these systems. >> >> config INTEL_SOC_PMIC_CHTWC >> - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC" >> + bool "Support for Intel Cherry Trail Whiskey Cove PMIC" >> depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK >> depends on X86 || COMPILE_TEST >> select MFD_CORE >