From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754094AbcICMX4 (ORCPT ); Sat, 3 Sep 2016 08:23:56 -0400 Received: from mout.web.de ([212.227.15.3]:55626 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbcICMXt (ORCPT ); Sat, 3 Sep 2016 08:23:49 -0400 Subject: [PATCH 08/17] s390/debug: Fix a jump target in debug_register_mode() To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 3 Sep 2016 14:23:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YYTaBQiMYShaC67Z7dIT7llX8Og8OicNVzX00kWBcoqy+5L7RAK MTw2zMrvMb+9G2Ojphha/FwG8YdjhJrRf/MsYdUatyl1kVdxjtsM/u4M7anycbuR3hGrYRP 43pEJEYX18YnbwrCN4UdQdZ95YaV5CFxRAKz6sJ13qHIWKl+0JzKGSq7phg5up+ddWlhAT5 HrPJDAGq1TSseamlf0Z3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:R4kMTVeOb08=:LVgXDONy8G+JvwEIYyPOlB tkvBiiyKfRYDtZxmlJ8RzR4jAQEQI/Y5QkMiWh/1yyOjv0ktXVYdapkh8P7j2K5D73xLfq/+u 1Ty+ZqLV1/dzGNZOax4LArpMywO3TFKPJ5SQ3nLpWJtJ2N+XXdbIUx6gsoRoIPg0s6OyR4+Jr eUkQ2cDT4nDTTjhjVbmlQuA3uXwFFhYpJCZ8LqDAvyZCFMW4gAjIzMeySzI00muLPYxBNlelm KxpeVekBmqhQjLMAN6EPyBR2yUUCKwJUYGPSDaTeJOcwz4zS0CHDJTPOp6k34z0MbD9Jkgcdm hUK/epeosexkJ/FwTsArnnOwuJ8I4T2C4Tp7RIubUMTc0oq34pDDOU+cx7xs+evjTAOqfK7ao 0GnBDjI5wfPhQP0CXCdLwrwvMfJoYZcucoB+YvBKZe5j/qTk0/ti9U4wM9dpn4Eo68PcD7BxS sL6YhcUAQAokZr4agW1akeXa3gJfCA8XQC7yh9Jt/A7qDrWoJDP33x7GQOBGW/y1Yg9pI92A7 V91BNSTWjjEQVD7tGWe5vW4eB/taRpr87EdTtHW8L15F8mRL1h2r/AZBLd9tUinOevZobOFMk hGlOVRlp1+IZMaVj78Ad/nQRDrarDEV+xh6Z9t7PXexGCl/lPnuKM+B/AFaxhUo8RRXWrD6Ah D1DDcdc74JVTPBefRSizZ3E6L/n3qlRoVFLzCPBzkBKc7OMhraMuyzYAH12ZyqjG1M+K+GDrz BxyU0MjuBwbFPvyUUkO5xcccOgf2ktdlZO1BYpwzXJQ9k8evEcRWRcFR/MCDjG03mmOy89g8x 0o7526p Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 1 Sep 2016 19:26:16 +0200 * Move an error message. * Adjust a jump target according to the current Linux coding style convention. * Delete a repeated check which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index 1cce76a..c4a4641 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -700,14 +700,14 @@ debug_info_t *debug_register_mode(const char *name, int pages_per_area, /* create new debug_info */ rc = debug_info_create(name, pages_per_area, nr_areas, buf_size, mode); - if (!rc) - goto out; + if (!rc) { + pr_err("Registering debug feature %s failed\n", name); + goto unlock; + } debug_register_view(rc, &debug_level_view); debug_register_view(rc, &debug_flush_view); debug_register_view(rc, &debug_pages_view); -out: - if (!rc) - pr_err("Registering debug feature %s failed\n", name); + unlock: mutex_unlock(&debug_mutex); return rc; } -- 2.9.3