From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87C8C433E1 for ; Thu, 20 Aug 2020 14:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8347720724 for ; Thu, 20 Aug 2020 14:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728396AbgHTOsO (ORCPT ); Thu, 20 Aug 2020 10:48:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:37066 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbgHTOsG (ORCPT ); Thu, 20 Aug 2020 10:48:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A0178AC6E; Thu, 20 Aug 2020 14:48:31 +0000 (UTC) Subject: Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set To: Konrad Rzeszutek Wilk , Randy Dunlap , Boris Ostrovsky Cc: LKML , linux-pci , Andy Shevchenko , Bjorn Helgaas , xen-devel References: <88afdd4a-1b30-d836-05ce-8919b834579b@infradead.org> <20200820144020.GA31230@char.us.oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Thu, 20 Aug 2020 16:48:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820144020.GA31230@char.us.oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.08.20 16:40, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 19, 2020 at 08:09:11PM -0700, Randy Dunlap wrote: >> Hi Konrad, > > Hey Randy, > > I believe Juergen is picking this up. Yes, have queued it for rc2. Juergen >> >> ping. >> >> I am still seeing this build error. It looks like this is >> in your territory to merge... >> >> >> On 8/13/20 4:00 PM, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix build error when CONFIG_ACPI is not set/enabled: >>> >>> ../arch/x86/pci/xen.c: In function ‘pci_xen_init’: >>> ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] >>> acpi_noirq_set(); >>> >>> Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef") >>> Signed-off-by: Randy Dunlap >>> Cc: Andy Shevchenko >>> Cc: Bjorn Helgaas >>> Cc: Konrad Rzeszutek Wilk >>> Cc: xen-devel@lists.xenproject.org >>> Cc: linux-pci@vger.kernel.org >>> --- >>> arch/x86/pci/xen.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> --- linux-next-20200813.orig/arch/x86/pci/xen.c >>> +++ linux-next-20200813/arch/x86/pci/xen.c >>> @@ -26,6 +26,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> >>> static int xen_pcifront_enable_irq(struct pci_dev *dev) >>> >> >> >> thanks. >> -- >> ~Randy >> >