linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiandi An <jiandi@amd.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>, Dave Airlie <airlied@linux.ie>,
	"open list:VIRTIO CORE,
	NET..."  <virtualization@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"Singh, Brijesh" <brijesh.singh@amd.com>
Subject: Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.
Date: Wed, 19 Sep 2018 07:15:06 +0000	[thread overview]
Message-ID: <d4c25272-9df8-33d6-d310-964b17a8c80d@amd.com> (raw)
In-Reply-To: <20180919044600.utvnu5l6fvvi2qi4@sirius.home.kraxel.org>



On 09/18/2018 11:46 PM, Gerd Hoffmann wrote:
>   Hi,
> 
>> buffer.  I tried to put a dma_sync_sg_for_device() on virtio_gpu_object obj->pages-sgl
>> before VIRTIO_GPU_CMD_TRANSFER_TO_HOST_2D is sent.  This fixes the kernel console path.
> 
> That should be the right place.
> 
>> Once display manger is kicked off for example (sudo systemctl start lightdm.service) and
>> resource id 3 gets created from user space down, it still gives a blank black screen.
> 
> Hmm.  I'd suspect there is simply a code path missing.  Can you send the
> patch you have?
> 
> cheers,
>   Gerd
> 

I sent the patch.  For now it does dma_sync_sg on the pages in 
TRANSFER_TO_HOST_2D/3D when use_dma_api is true.

https://lore.kernel.org/lkml/20180919070931.91168-1-jiandi.an@amd.com/

- Jiandi

  reply	other threads:[~2018-09-19  7:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180829122026.27012-1-kraxel@redhat.com>
2018-08-29 12:20 ` [PATCH 1/2] drm/virtio: add virtio_gpu_object_detach() function Gerd Hoffmann
2018-08-29 12:20 ` [PATCH 2/2] drm/virtio: add iommu support Gerd Hoffmann
2018-09-03 23:50   ` [virtio-dev] " Dave Airlie
2018-09-12  6:52     ` Jiandi An
2018-09-12  7:25       ` Gerd Hoffmann
2018-09-18 17:51         ` Jiandi An
2018-09-19  4:46           ` Gerd Hoffmann
2018-09-19  7:15             ` Jiandi An [this message]
2018-09-19 11:38               ` Gerd Hoffmann
2018-09-19 22:06                 ` Jiandi An
2018-09-20  6:32                   ` Gerd Hoffmann
2018-09-21  4:58                     ` Jiandi An
2018-09-21  5:47                       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c25272-9df8-33d6-d310-964b17a8c80d@amd.com \
    --to=jiandi@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=brijesh.singh@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).