linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, joe@perches.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH v4 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition in core/rtw_pwrctrl.c
Date: Sun,  4 Apr 2021 16:09:26 +0200	[thread overview]
Message-ID: <d4d1d256586cbdfc55157b0b384b28d53a61c2b8.1617545239.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1617545239.git.fabioaiuto83@gmail.com>

fix following post-commit hook checkpatch issues:

CHECK: Unnecessary parentheses around 'pwrpriv->rpwm == pslv'
26: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:269:
+		if ((pwrpriv->rpwm == pslv) ||
+		    ((pwrpriv->rpwm >= PS_STATE_S2)
	&& (pslv >= PS_STATE_S2)))

CHECK: Unnecessary parentheses around 'pwrpriv->rpwm >= PS_STATE_S2'
26: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:269:
+		if ((pwrpriv->rpwm == pslv) ||
+		    ((pwrpriv->rpwm >= PS_STATE_S2)
	&& (pslv >= PS_STATE_S2)))

CHECK: Unnecessary parentheses around 'pslv >= PS_STATE_S2'
26: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:269:
+		if ((pwrpriv->rpwm == pslv) ||
+		    ((pwrpriv->rpwm >= PS_STATE_S2)
	&& (pslv >= PS_STATE_S2)))

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index fa06144337ce..09bf25940e92 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -266,8 +266,8 @@ void rtw_set_rpwm(struct adapter *padapter, u8 pslv)
 	if (pwrpriv->brpwmtimeout) {
 		DBG_871X("%s: RPWM timeout, force to set RPWM(0x%02X) again!\n", __func__, pslv);
 	} else {
-		if ((pwrpriv->rpwm == pslv) ||
-		    ((pwrpriv->rpwm >= PS_STATE_S2) && (pslv >= PS_STATE_S2)))
+		if (pwrpriv->rpwm == pslv ||
+		    (pwrpriv->rpwm >= PS_STATE_S2 && pslv >= PS_STATE_S2))
 			return;
 
 	}
-- 
2.20.1


  parent reply	other threads:[~2021-04-04 14:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 14:09 [PATCH v4 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 02/30] staging: rtl8723bs: fix condition in if statement " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 04/30] staging: rtl8723bs: fix line exceed warning " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 05/30] staging: rtl8723bs: fix spaces around operator issues " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 07/30] staging: rtl8723bs: fix error prone if conditions " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 09/30] staging: rtl8723bs: fix logical continuation issue " Fabio Aiuto
2021-04-04 14:09 ` Fabio Aiuto [this message]
2021-04-04 14:09 ` [PATCH v4 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 12/30] staging: rtl8723bs: fix null check conditions " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 15/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 16/30] staging: rtl8723bs: tidy up some error handling " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 19/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 20/30] staging: rtl8723bs: added spaces around operator " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 21/30] staging: rtl8723bs: split long line " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 22/30] staging: rtl8723bs: remove unnecessary parentheses " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 23/30] staging: rtl8723bs: fix comparison in if condition " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 25/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 26/30] staging: rtl8723bs: place constant on the right side of the test " Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c Fabio Aiuto
2021-04-04 14:09 ` [PATCH v4 30/30] staging: rtl8723bs: add spaces around operators " Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4d1d256586cbdfc55157b0b384b28d53a61c2b8.1617545239.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).