From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49D3C43331 for ; Sat, 28 Mar 2020 02:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 798712073B for ; Sat, 28 Mar 2020 02:14:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="svL5J53V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbgC1COg (ORCPT ); Fri, 27 Mar 2020 22:14:36 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:64081 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgC1COf (ORCPT ); Fri, 27 Mar 2020 22:14:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585361675; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=pjqoOw4JJUHMqq1BpJRNs2QP7YFv72GeeTwA5RNFhyQ=; b=svL5J53Vfy3HbbLeb1F968Wl6JRbAGFlpEk9PmUsTpLLh7cZiaGsLrII1uB42EekqCWowVN6 IqOtkZJ0vhsmOsVwdzGKBz426Q0Io7Pvdw5/Tm4U6E5d7GVfDNg/IPjWmas5Y1HnC8FtqPsq zCKraJH5Hb1wk6jmycZBZuZUDOc= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7eb307.7f6558242650-smtp-out-n01; Sat, 28 Mar 2020 02:14:31 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E8A5FC4478C; Sat, 28 Mar 2020 02:14:30 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7CF97C433F2; Sat, 28 Mar 2020 02:14:29 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 28 Mar 2020 10:14:29 +0800 From: Can Guo To: Stanley Chu Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com Subject: Re: [PATCH v1 1/1] scsi: ufs: set device as active power mode after resetting device In-Reply-To: <20200327095835.10293-1-stanley.chu@mediatek.com> References: <20200327095835.10293-1-stanley.chu@mediatek.com> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-27 17:58, Stanley Chu wrote: > Currently ufshcd driver assumes that bInitPowerMode parameter > is not changed by any vendors thus device power mode can be set as > "Active" during initialization. > > According to UFS JEDEC specification, device power mode shall be > "Active" after HW Reset is triggered if the bInitPowerMode parameter > in Device Descriptor is default value. > > By above description, we can set device power mode as "Active" after > device reset is triggered by vendor's callback. With this change, > the link startup performance can be improved in some cases > by not setting link_startup_again as true in ufshcd_link_startup(). > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 13 ------------- > drivers/scsi/ufs/ufshcd.h | 14 ++++++++++++++ > 2 files changed, 14 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 227660a1a446..f0a35b289b7c 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -171,19 +171,6 @@ enum { > #define ufshcd_clear_eh_in_progress(h) \ > ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) > > -#define ufshcd_set_ufs_dev_active(h) \ > - ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) > -#define ufshcd_set_ufs_dev_sleep(h) \ > - ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) > -#define ufshcd_set_ufs_dev_poweroff(h) \ > - ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) > -#define ufshcd_is_ufs_dev_active(h) \ > - ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) > -#define ufshcd_is_ufs_dev_sleep(h) \ > - ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) > -#define ufshcd_is_ufs_dev_poweroff(h) \ > - ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) > - > struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { > {UFS_ACTIVE_PWR_MODE, UIC_LINK_ACTIVE_STATE}, > {UFS_ACTIVE_PWR_MODE, UIC_LINK_HIBERN8_STATE}, > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index b7bd81795c24..7a9d1d170719 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -129,6 +129,19 @@ enum uic_link_state { > #define ufshcd_set_link_hibern8(hba) ((hba)->uic_link_state = \ > UIC_LINK_HIBERN8_STATE) > > +#define ufshcd_set_ufs_dev_active(h) \ > + ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) > +#define ufshcd_set_ufs_dev_sleep(h) \ > + ((h)->curr_dev_pwr_mode = UFS_SLEEP_PWR_MODE) > +#define ufshcd_set_ufs_dev_poweroff(h) \ > + ((h)->curr_dev_pwr_mode = UFS_POWERDOWN_PWR_MODE) > +#define ufshcd_is_ufs_dev_active(h) \ > + ((h)->curr_dev_pwr_mode == UFS_ACTIVE_PWR_MODE) > +#define ufshcd_is_ufs_dev_sleep(h) \ > + ((h)->curr_dev_pwr_mode == UFS_SLEEP_PWR_MODE) > +#define ufshcd_is_ufs_dev_poweroff(h) \ > + ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) > + > /* > * UFS Power management levels. > * Each level is in increasing order of power savings. > @@ -1091,6 +1104,7 @@ static inline void > ufshcd_vops_device_reset(struct ufs_hba *hba) > { > if (hba->vops && hba->vops->device_reset) { > hba->vops->device_reset(hba); > + ufshcd_set_ufs_dev_active(hba); > ufshcd_update_reg_hist(&hba->ufs_stats.dev_reset, 0); > } > } Reviewed-by: Can Guo