linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Chang Yu <marcus.yu.56@gmail.com>, Larry.Finger@lwfinger.net
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: combine nested if statements into one
Date: Thu, 23 Jun 2022 06:58:31 +0200	[thread overview]
Message-ID: <d50c16c1-0bc2-fdc4-16ab-0c27df824ffb@gmail.com> (raw)
In-Reply-To: <20220623031515.402691-1-marcus.yu.56@gmail.com>

On 6/23/22 05:15, Chang Yu wrote:
> -	if (padapter) {
> -		if (pfree_recv_queue == &precvpriv->free_recv_queue)
> -				precvpriv->free_recvframe_cnt++;
> -	}
> +	if (padapter && pfree_recv_queue == &precvpriv->free_recv_queue)
> +		precvpriv->free_recvframe_cnt++;

Hi

tested with:
#include <stdio.h>
int main() {
     char padapter = 1;
     int pfree_recv_queue = 256;
     int free_recv_queue = 256;

     if (padapter) {
     	if (pfree_recv_queue == free_recv_queue)
             printf("Executed before patch: 
precvpriv->free_recvframe_cnt++;\n");
     }

     if (padapter && pfree_recv_queue == free_recv_queue)
		printf("Executed after patch: precvpriv->free_recvframe_cnt++;\n");

    return 0;
}

Seems to work. But the rules which operation is done first && or == are 
not too easy. I would prefer to have:

if (padapter && (pfree_recv_queue == free_recv_queue))

So it is very easy to read what is evaluated first.

But this is just my opinion and does not have to be right.

Thanks for your patch.

Bye Philipp

  reply	other threads:[~2022-06-23  5:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23  3:15 [PATCH] staging: r8188eu: combine nested if statements into one Chang Yu
2022-06-23  4:58 ` Philipp Hortmann [this message]
2022-06-23 12:05   ` David Laight
2022-06-24  3:30     ` Chang Yu
2022-06-24  5:26       ` Philipp Hortmann
2022-06-23  5:14 ` [PATCH v2] " Chang Yu
2022-06-23  5:53   ` Philipp Hortmann
2022-06-23  9:45   ` Greg KH
2022-06-24  3:34     ` Chang Yu
2022-06-24  5:39       ` Dan Carpenter
2022-06-24  5:52         ` Chang Yu
2022-06-24  5:47       ` Philipp Hortmann
2022-06-24  5:59         ` Chang Yu
2022-06-24  6:27 ` [PATCH v3] staging: r8188eu: core/rtw_recv.c: clean up nested if statements Chang Yu
2022-06-24  6:42   ` Greg KH
2022-06-24 14:45 ` [PATCH v4] " Chang Yu
2022-06-24 18:01   ` Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d50c16c1-0bc2-fdc4-16ab-0c27df824ffb@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcus.yu.56@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).