From: Miaohe Lin <linmiaohe@huawei.com>
To: David Hildenbrand <david@redhat.com>, <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>,
John Hubbard <jhubbard@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Yang Shi <shy828301@gmail.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
Michal Hocko <mhocko@kernel.org>, Nadav Amit <namit@vmware.com>,
Rik van Riel <riel@surriel.com>, Roman Gushchin <guro@fb.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Xu <peterx@redhat.com>, Donald Dutile <ddutile@redhat.com>,
Christoph Hellwig <hch@lst.de>, Oleg Nesterov <oleg@redhat.com>,
Jan Kara <jack@suse.cz>, Liang Zhang <zhangliang5@huawei.com>,
Pedro Gomes <pedrodemargomes@gmail.com>,
Oded Gabbay <oded.gabbay@gmail.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH v4 12/17] mm: remember exclusively mapped anonymous pages with PG_anon_exclusive
Date: Tue, 6 Dec 2022 17:37:31 +0800 [thread overview]
Message-ID: <d51a7163-b082-d43a-1d0d-13ebf8cb538d@huawei.com> (raw)
In-Reply-To: <3c7fd5da-b3f8-5562-45a9-f83d7dbcdd7d@redhat.com>
On 2022/12/6 16:43, David Hildenbrand wrote:
>>>
>>
>> Hi David, sorry for the late respond and a possible inconsequential question. :)
>
> Better late than never! Thanks for the review, independently at which time it happens :)
>
>>
>> <snip>
>>
>>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>>> index 7a71ed679853..5add8bbd47cd 100644
>>> --- a/mm/hugetlb.c
>>> +++ b/mm/hugetlb.c
>>> @@ -4772,7 +4772,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
>>> is_hugetlb_entry_hwpoisoned(entry))) {
>>> swp_entry_t swp_entry = pte_to_swp_entry(entry);
>>> - if (is_writable_migration_entry(swp_entry) && cow) {
>>> + if (!is_readable_migration_entry(swp_entry) && cow) {
>>> /*
>>> * COW mappings require pages in both
>>> * parent and child to be set to read.
>>> @@ -5172,6 +5172,8 @@ static vm_fault_t hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma,
>>> set_huge_ptep_writable(vma, haddr, ptep);
>>> return 0;
>>> }
>>> + VM_BUG_ON_PAGE(PageAnon(old_page) && PageAnonExclusive(old_page),
>>> + old_page);
>>> /*
>>> * If the process that created a MAP_PRIVATE mapping is about to
>>> @@ -6169,12 +6171,17 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
>>> }
>>> if (unlikely(is_hugetlb_entry_migration(pte))) {
>>> swp_entry_t entry = pte_to_swp_entry(pte);
>>> + struct page *page = pfn_swap_entry_to_page(entry);
>>> - if (is_writable_migration_entry(entry)) {
>>> + if (!is_readable_migration_entry(entry)) {
>>
>> In hugetlb_change_protection(), is_writable_migration_entry() is changed to !is_readable_migration_entry(),
>> but
>>
>>> pte_t newpte;
>>> - entry = make_readable_migration_entry(
>>> - swp_offset(entry));
>>> + if (PageAnon(page))
>>> + entry = make_readable_exclusive_migration_entry(
>>> + swp_offset(entry));
>>> + else
>>> + entry = make_readable_migration_entry(
>>> + swp_offset(entry));
>>> newpte = swp_entry_to_pte(entry);
>>> set_huge_swap_pte_at(mm, address, ptep,
>>> newpte, huge_page_size(h));
>>
>> <snip>
>>
>>> diff --git a/mm/mprotect.c b/mm/mprotect.c
>>> index b69ce7a7b2b7..56060acdabd3 100644
>>> --- a/mm/mprotect.c
>>> +++ b/mm/mprotect.c
>>> @@ -152,6 +152,7 @@ static unsigned long change_pte_range(struct vm_area_struct *vma, pmd_t *pmd,
>>> pages++;
>>> } else if (is_swap_pte(oldpte)) {
>>> swp_entry_t entry = pte_to_swp_entry(oldpte);
>>> + struct page *page = pfn_swap_entry_to_page(entry);
>>> pte_t newpte;
>>> if (is_writable_migration_entry(entry)) {
>>
>> In change_pte_range(), is_writable_migration_entry() is not changed to !is_readable_migration_entry().
>
> Yes, and also in change_huge_pmd(), is_writable_migration_entry() stays unchanged.
>
>> Is this done intentionally? Could you tell me why there's such a difference? I'm confused. It's very
>> kind of you if you can answer my puzzle.
>
> For change protection, the only relevant part is to convert writable -> readable or writable -> readable_exclusive.
>
> If an entry is already readable or readable_exclusive, there is nothing to do. The only issues would be when turning a readable one into a readable_exclusive one or a readable_exclusive one into a readable one.
>
>
> In hugetlb_change_protection(), the "!is_readable_migration_entry" could in fact be turned into a "is_writable_migration_entry()". Right now, it would convert writable -> readable or writable -> readable_exclusive AND readable -> readable AND readable_exclusive -> readable_exclusive, which isn't necessary but also shouldn't hurt either.
Many thanks for your explanation. It's really helpful. :)
>
>
> So yeah, it's not consistent but shouldn't be problematic. Do you see an issue with that?
No, I don't see any issue with that. I just wonder whether we can change "!is_readable_migration_entry" to "is_writable_migration_entry()" to make code
more consistent and avoid possible future puzzle. Also we can further remove this harmless unnecessary migration entry conversion. But this should
be a separate cleanup patch anyway.
>
> It would be great to extend the "selftest/vm cow" test to also cover migration entries, however, that requires slightly more work and "luck" to fork() while migration is happening.
>
> Thanks!
Many thanks for your work!
Thanks,
Miaohe Lin
>
next prev parent reply other threads:[~2022-12-06 9:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 8:34 [PATCH v4 00/17] mm: COW fixes part 2: reliable GUP pins of anonymous pages David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 01/17] mm/rmap: fix missing swap_free() in try_to_unmap() after arch_unmap_one() failed David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 02/17] mm/hugetlb: take src_mm->write_protect_seq in copy_hugetlb_page_range() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 03/17] mm/memory: slightly simplify copy_present_pte() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 04/17] mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 05/17] mm/rmap: convert RMAP flags to a proper distinct rmap_t type David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 06/17] mm/rmap: remove do_page_add_anon_rmap() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 07/17] mm/rmap: pass rmap flags to hugepage_add_anon_rmap() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 08/17] mm/rmap: drop "compound" parameter from page_add_new_anon_rmap() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 09/17] mm/rmap: use page_move_anon_rmap() when reusing a mapped PageAnon() page exclusively David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 10/17] mm/huge_memory: remove outdated VM_WARN_ON_ONCE_PAGE from unmap_page() David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 11/17] mm/page-flags: reuse PG_mappedtodisk as PG_anon_exclusive for PageAnon() pages David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 12/17] mm: remember exclusively mapped anonymous pages with PG_anon_exclusive David Hildenbrand
2022-04-29 18:26 ` Andrew Morton
2022-04-29 18:56 ` David Hildenbrand
2022-12-06 3:05 ` Miaohe Lin
2022-12-06 8:43 ` David Hildenbrand
2022-12-06 9:37 ` Miaohe Lin [this message]
2022-12-06 9:40 ` David Hildenbrand
2022-12-06 11:28 ` Miaohe Lin
2022-04-28 8:34 ` [PATCH v4 13/17] mm/rmap: fail try_to_migrate() early when setting a PMD migration entry fails David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 14/17] mm/gup: disallow follow_page(FOLL_PIN) David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 15/17] mm: support GUP-triggered unsharing of anonymous pages David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 16/17] mm/gup: trigger FAULT_FLAG_UNSHARE when R/O-pinning a possibly shared anonymous page David Hildenbrand
2022-04-28 8:34 ` [PATCH v4 17/17] mm/gup: sanity-check with CONFIG_DEBUG_VM that anonymous pages are exclusive when (un)pinning David Hildenbrand
2022-04-28 8:37 ` [PATCH v4 00/17] mm: COW fixes part 2: reliable GUP pins of anonymous pages David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d51a7163-b082-d43a-1d0d-13ebf8cb538d@huawei.com \
--to=linmiaohe@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ddutile@redhat.com \
--cc=guro@fb.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=namit@vmware.com \
--cc=oded.gabbay@gmail.com \
--cc=oleg@redhat.com \
--cc=pedrodemargomes@gmail.com \
--cc=peterx@redhat.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rppt@linux.ibm.com \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=zhangliang5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).