From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
cw00.choi@samsung.com, b.zolnierkie@samsung.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: max77686: Remove some dead code
Date: Mon, 10 May 2021 08:18:48 -0400 [thread overview]
Message-ID: <d5250408-b899-ab1a-c86c-0366b6b286c3@canonical.com> (raw)
In-Reply-To: <a6b23ee8d3ea78f62d3fda0b53aa273718f14c6d.1620452523.git.christophe.jaillet@wanadoo.fr>
On 08/05/2021 01:43, Christophe JAILLET wrote:
> 'ret' is known to be an error pointer here, so it can't be 0.
> Remove this dead code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/rtc/rtc-max77686.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
> index d51cc12114cb..ce089ed934ad 100644
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -764,8 +764,6 @@ static int max77686_rtc_probe(struct platform_device *pdev)
> if (IS_ERR(info->rtc_dev)) {
> ret = PTR_ERR(info->rtc_dev);
> dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
> - if (ret == 0)
> - ret = -EINVAL;
> goto err_rtc;
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2021-05-10 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 5:43 [PATCH] rtc: max77686: Remove some dead code Christophe JAILLET
2021-05-08 14:38 ` Edmundo Carmona Antoranz
2021-05-08 16:59 ` Christophe JAILLET
2021-05-09 0:06 ` Edmundo Carmona Antoranz
2021-05-09 21:06 ` Alexandre Belloni
2021-05-10 12:20 ` Krzysztof Kozlowski
2021-05-12 16:13 ` Alexandre Belloni
2021-05-12 16:24 ` Krzysztof Kozlowski
2021-05-12 16:54 ` Alexandre Belloni
2021-05-12 20:02 ` Christophe JAILLET
2021-05-12 21:22 ` Alexandre Belloni
2021-05-10 12:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5250408-b899-ab1a-c86c-0366b6b286c3@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cw00.choi@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).