linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Ken Chen" <j220584470k@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Joel Stanley" <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	"Potin Lai" <Potin.Lai@quantatw.com>,
	Cosmo.Chou@quantatw.com, "Michael Garner" <garnermic@fb.com>
Subject: Re: [PATCH 1/1] ARM: dts: aspeed-g6: enable more UART controllers
Date: Mon, 08 Aug 2022 10:00:08 +0930	[thread overview]
Message-ID: <d52e126e-3dc3-4645-a9f0-2f4e3411010a@www.fastmail.com> (raw)
In-Reply-To: <20220805090957.470434-1-j220584470k@gmail.com>



On Fri, 5 Aug 2022, at 18:39, Ken Chen wrote:
> Setup the configuration of UART6, UART7, UART8, and UART9 in
> aspeed-g6.dtsi.
>
> Signed-off-by: Ken Chen <j220584470k@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-g6.dtsi | 64 +++++++++++++++++++++++++++++++-
>  1 file changed, 62 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 8c0de3f27883b..fe7cef6b5e976 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -34,8 +34,12 @@ aliases {
>  		serial2 = &uart3;
>  		serial3 = &uart4;
>  		serial4 = &uart5;
> -		serial5 = &vuart1;
> -		serial6 = &vuart2;
> +		serial5 = &uart6;
> +		serial6 = &uart7;
> +		serial7 = &uart8;
> +		serial8 = &uart9;
> +		serial9 = &vuart1;
> +		serial10 = &vuart2;
>  	};
> 

Have you tested the AST2600 systems in OpenBMC with this patch to see 
if you're not breaking any assumptions made by userspace about serial 
numbering, given the aliases exist?

Andrew

  reply	other threads:[~2022-08-08  0:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  9:09 [PATCH 1/1] ARM: dts: aspeed-g6: enable more UART controllers Ken Chen
2022-08-08  0:30 ` Andrew Jeffery [this message]
2022-09-27  7:57 ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d52e126e-3dc3-4645-a9f0-2f4e3411010a@www.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=Cosmo.Chou@quantatw.com \
    --cc=Potin.Lai@quantatw.com \
    --cc=devicetree@vger.kernel.org \
    --cc=garnermic@fb.com \
    --cc=j220584470k@gmail.com \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).