From: Paolo Bonzini <pbonzini@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>,
Andrew Jones <drjones@redhat.com>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/kvm: add get_msr_index_features
Date: Fri, 19 Mar 2021 09:16:59 +0100 [thread overview]
Message-ID: <d556faf6-fcf4-ec64-546e-ab80b107751e@redhat.com> (raw)
In-Reply-To: <52d09cdf-3819-0cd8-5812-387febaa1ab3@redhat.com>
On 19/03/21 09:07, Emanuele Giuseppe Esposito wrote:
>>
>> I'm not sure why the original kvm selftests authors decided to do this
>> internal stuff, but we should either kill that or avoid doing stuff like
>> this.
>
> I need this include because of the KVM_DEV_PATH macro, to get the kvm_fd.
> No other reason for including it in this test.
I'll take care of moving that macro to the non-internal kvm_util.h
header, thanks.
No need to do anything, I'll send the pull request later today.
Paolo
prev parent reply other threads:[~2021-03-19 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 14:56 [PATCH] selftests/kvm: add get_msr_index_features Emanuele Giuseppe Esposito
2021-03-18 15:35 ` Paolo Bonzini
2021-03-18 17:03 ` Andrew Jones
2021-03-18 17:33 ` Paolo Bonzini
2021-03-18 17:55 ` Andrew Jones
2021-03-18 18:46 ` Sean Christopherson
2021-03-19 8:07 ` Emanuele Giuseppe Esposito
2021-03-19 8:16 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d556faf6-fcf4-ec64-546e-ab80b107751e@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=eesposit@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).