Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations

From: Stefan Agner <stefan@agner.ch>
To: Joe Perches <joe@perches.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jslaby@suse.cz>,
	linux-ia64@vger.kernel.org, kernel@stlinux.com,
	"Nicolas Ferre" <nicolas.ferre@atmel.com>,
	"Timur Tabi" <timur@tabi.org>,
	linux-kernel@vger.kernel.org, "Pat Gefre" <pfg@sgi.com>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	"Daniel Walker" <dwalker@fifo99.com>,
	sparclinux@vger.kernel.org, "Peter Korsgaard" <jacmet@sunsite.dk>,
	"Sonic Zhang" <sonic.zhang@analog.com>,
	"Alexandre Courbot" <gnurou@gmail.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Michal Simek" <michal.simek@xilinx.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org,
	"Tobias Klauser" <tklauser@distanz.ch>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	linux-arm-msm@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	"Thadeu Lima de Souza Cascardo" <cascardo@linux.vnet.ibm.com>,
	linux-tegra@vger.kernel.org,
	"David Brown" <davidb@codeaurora.org>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Maxime Coquelin" <maxime.coquelin@st.com>,
	"Barry Song" <baohua@kernel.org>,
	"Vineet Gupta" <vgupta@synopsys.com>,
	"Patrice Chotard" <patrice.chotard@st.com>,
	"Tony Prisk" <linux@prisktech.co.nz>,
	"Bryan Huntsman" <bryanh@codeaurora.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <kernel@pengutronix.de>,
	"Srinivas Kandagatla" <srinivas.kandagatla@gmail.com>,
	nios2-dev@lists.rocketboards.org,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations
Date: Mon, 06 Apr 2015 01:09:06 +0200	[thread overview]
Message-ID: <d55b1a1240db66ae651cb99cd713694a@agner.ch> (raw)
In-Reply-To: <1428258294.2775.69.camel@perches.com>

On 2015-04-05 20:24, Joe Perches wrote:
> Still compiled only x86 and not cross-compiled or tested.

Cross-compiled with multi_v7_defconfig

> 
>  drivers/tty/serial/21285.c                  | 2 +-
>  drivers/tty/serial/altera_jtaguart.c        | 2 +-
>  drivers/tty/serial/altera_uart.c            | 2 +-
>  drivers/tty/serial/amba-pl010.c             | 2 +-
>  drivers/tty/serial/amba-pl011.c             | 2 +-
>  drivers/tty/serial/apbuart.c                | 2 +-
>  drivers/tty/serial/ar933x_uart.c            | 2 +-
>  drivers/tty/serial/arc_uart.c               | 2 +-
>  drivers/tty/serial/atmel_serial.c           | 2 +-
>  drivers/tty/serial/bcm63xx_uart.c           | 2 +-
>  drivers/tty/serial/bfin_sport_uart.c        | 2 +-
>  drivers/tty/serial/bfin_uart.c              | 2 +-
>  drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 +-
>  drivers/tty/serial/dz.c                     | 2 +-
>  drivers/tty/serial/efm32-uart.c             | 2 +-
>  drivers/tty/serial/fsl_lpuart.c             | 4 ++--

Tested that driver on actual hardware, looks fine.

>  drivers/tty/serial/icom.c                   | 2 +-
>  drivers/tty/serial/imx.c                    | 2 +-
>  drivers/tty/serial/ioc3_serial.c            | 2 +-
>  drivers/tty/serial/ioc4_serial.c            | 2 +-
>  drivers/tty/serial/ip22zilog.c              | 2 +-
>  drivers/tty/serial/jsm/jsm_tty.c            | 2 +-
>  drivers/tty/serial/lantiq.c                 | 2 +-
>  drivers/tty/serial/lpc32xx_hs.c             | 2 +-
>  drivers/tty/serial/m32r_sio.c               | 2 +-
>  drivers/tty/serial/max3100.c                | 2 +-
>  drivers/tty/serial/men_z135_uart.c          | 2 +-
>  drivers/tty/serial/meson_uart.c             | 2 +-
>  drivers/tty/serial/mpc52xx_uart.c           | 2 +-
>  drivers/tty/serial/mpsc.c                   | 2 +-
>  drivers/tty/serial/msm_serial.c             | 2 +-
>  drivers/tty/serial/mux.c                    | 2 +-
>  drivers/tty/serial/mxs-auart.c              | 2 +-
>  drivers/tty/serial/netx-serial.c            | 2 +-
>  drivers/tty/serial/nwpserial.c              | 2 +-
>  drivers/tty/serial/omap-serial.c            | 2 +-
>  drivers/tty/serial/pch_uart.c               | 2 +-
>  drivers/tty/serial/pmac_zilog.c             | 2 +-
>  drivers/tty/serial/pnx8xxx_uart.c           | 2 +-
>  drivers/tty/serial/pxa.c                    | 2 +-
>  drivers/tty/serial/sa1100.c                 | 2 +-
>  drivers/tty/serial/samsung.c                | 2 +-

This driver seems to alter the startup function on initialization:

  CC      drivers/video/of_display_timing.o
../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
../drivers/tty/serial/samsung.c:1702:3: error: assignment of member
'startup' in read-only object
   s3c24xx_serial_ops.startup = s3c64xx_serial_startup;
   ^

>  drivers/tty/serial/serial-tegra.c           | 2 +-
>  drivers/tty/serial/serial_ks8695.c          | 2 +-
>  drivers/tty/serial/serial_txx9.c            | 2 +-
>  drivers/tty/serial/sh-sci.c                 | 2 +-
>  drivers/tty/serial/sirfsoc_uart.c           | 2 +-
>  drivers/tty/serial/sn_console.c             | 2 +-
>  drivers/tty/serial/sprd_serial.c            | 2 +-
>  drivers/tty/serial/st-asc.c                 | 2 +-
>  drivers/tty/serial/sunhv.c                  | 2 +-
>  drivers/tty/serial/sunsab.c                 | 2 +-
>  drivers/tty/serial/sunsu.c                  | 2 +-
>  drivers/tty/serial/sunzilog.c               | 2 +-
>  drivers/tty/serial/timbuart.c               | 2 +-
>  drivers/tty/serial/uartlite.c               | 2 +-
>  drivers/tty/serial/ucc_uart.c               | 2 +-
>  drivers/tty/serial/vr41xx_siu.c             | 2 +-
>  drivers/tty/serial/vt8500_serial.c          | 2 +-
>  drivers/tty/serial/xilinx_uartps.c          | 2 +-
>  drivers/tty/serial/zs.c                     | 2 +-
>  61 files changed, 62 insertions(+), 62 deletions(-)

That is the only thing which popped up with multi_v7_defconfig.

--
Stefan