From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFFCC43460 for ; Mon, 12 Apr 2021 12:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC8B061288 for ; Mon, 12 Apr 2021 12:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241511AbhDLM5g (ORCPT ); Mon, 12 Apr 2021 08:57:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239454AbhDLM5f (ORCPT ); Mon, 12 Apr 2021 08:57:35 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D533C061574; Mon, 12 Apr 2021 05:57:17 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id d23so1056383qko.12; Mon, 12 Apr 2021 05:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/U/PfNnIacHN6/B+3pGZEPy3lv6e1Ed7uOyTxH72DkA=; b=bw/sEW0qGhzcmGaiOFtncmE1g+YPNHIpnr9u5Z425d5XKLGrKJpzIlcuWqu7yjjNcS L878OxiHnUV5TUGOODcRV571J/Himk2gMB8iVhbSh7opcZ8DUmX8BnY/F/AkG1aNUGwA nTloeAxdExDAnbC5jQLqIHSRWTgBQEg4wm71wj7V976c6k1o2YV9vofWTu0N9W+QhjZC YhAjARvHdvbPhiXRZpJGYGSy93O3KJ+aZ5cAH1GLANZroSMprUo574ngEfXMMrBK6IfK AdrM8sBnLZvnYZ9SpIKptUpJu2H0GzHP8QdpIAdJ4KGQfA30I/qDPAHiPK4Nke/5VQXS GTKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/U/PfNnIacHN6/B+3pGZEPy3lv6e1Ed7uOyTxH72DkA=; b=ApLg3dy+1WSgkDBqO2+2DeEowAk5177gUaLwkWT4VtJ/o7RYfX/0yb2PZ6yZJrlf/z 2GNoQcEKKdBVmsVlsGlfHctzI0vqi2dL8zcY/c8jJUFgZRiyqofSgKRQCiS13JNY69zI 09aIbTUKLmWsm5JEjd88TwVVS/qnk21kYmUofi0NQkyQ9WhBwvQSZIi0FL4OzXozBIaU Dsu1ybLQ6tetjmhxnM2HqyYsscRqpKk3SDGVOhEiYSZZRO/CVGjmabF/u9jCXgLnfeK4 koVzHKksFM/T28Q9CEbAzz58wUW0WRzCjXVvHDkwiMQJ4xo1u8WZ5AOJIuIiGMFXoK0y DttQ== X-Gm-Message-State: AOAM531H/KMvdM24I4G+rM1+g7cscCEK/QMAB62nCUBrML0jTJYFz9VN U6E3Cyhx+/rB7/6rsvAtSqY= X-Google-Smtp-Source: ABdhPJyNvSltvpQEMt3poQvp/nizkUIggjZx0AHSdfGNr2QlJDdV6lwNp0TbWekvmaqLeAnWALmZrQ== X-Received: by 2002:a05:620a:1592:: with SMTP id d18mr4864123qkk.329.1618232236956; Mon, 12 Apr 2021 05:57:16 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id y29sm7745488qtm.13.2021.04.12.05.57.16 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:57:16 -0700 (PDT) Date: Mon, 12 Apr 2021 09:57:14 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 2/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss_ipipe.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro --- Changes since v1: - Insert file path in commit message drivers/staging/media/omap4iss/iss_ipipe.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c index 26be078..09c941c 100644 --- a/drivers/staging/media/omap4iss/iss_ipipe.c +++ b/drivers/staging/media/omap4iss/iss_ipipe.c @@ -38,9 +38,11 @@ static const unsigned int ipipe_fmts[] = { * * Also prints other debug information stored in the IPIPE module. */ -#define IPIPE_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)) +static inline ipipe_print_register(iss, name) +{ + dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)); +} static void ipipe_print_status(struct iss_ipipe_device *ipipe) { @@ -48,16 +50,16 @@ static void ipipe_print_status(struct iss_ipipe_device *ipipe) dev_dbg(iss->dev, "-------------IPIPE Register dump-------------\n"); - IPIPE_PRINT_REGISTER(iss, SRC_EN); - IPIPE_PRINT_REGISTER(iss, SRC_MODE); - IPIPE_PRINT_REGISTER(iss, SRC_FMT); - IPIPE_PRINT_REGISTER(iss, SRC_COL); - IPIPE_PRINT_REGISTER(iss, SRC_VPS); - IPIPE_PRINT_REGISTER(iss, SRC_VSZ); - IPIPE_PRINT_REGISTER(iss, SRC_HPS); - IPIPE_PRINT_REGISTER(iss, SRC_HSZ); - IPIPE_PRINT_REGISTER(iss, GCK_MMR); - IPIPE_PRINT_REGISTER(iss, YUV_PHS); + ipipe_print_register(iss, SRC_EN); + ipipe_print_register(iss, SRC_MODE); + ipipe_print_register(iss, SRC_FMT); + ipipe_print_register(iss, SRC_COL); + ipipe_print_register(iss, SRC_VPS); + ipipe_print_register(iss, SRC_VSZ); + ipipe_print_register(iss, SRC_HPS); + ipipe_print_register(iss, SRC_HSZ); + ipipe_print_register(iss, GCK_MMR); + ipipe_print_register(iss, YUV_PHS); dev_dbg(iss->dev, "-----------------------------------------------\n"); } -- 2.7.4