From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, alex.g@adaptrum.com
Cc: gokhan@adaptrum.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed
Date: Mon, 14 Nov 2016 13:25:56 -0800 [thread overview]
Message-ID: <d567c69f-6b57-7083-9090-df01fb140e36@gmail.com> (raw)
In-Reply-To: <20161114.161818.1460191406108019273.davem@davemloft.net>
On 11/14/2016 01:18 PM, David Miller wrote:
> From: Alexandru Gagniuc <alex.g@adaptrum.com>
> Date: Sat, 12 Nov 2016 15:32:13 -0800
>
>> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
>> + ret = vsc8601_add_skew(phydev);
>
> I think you should use phy_interface_is_rgmii() here.
>
This would include all RGMII modes, here I think the intent is to check
for PHY_INTERFACE_MODE_RGMII_ID and PHY_INTERFACE_MODE_RGMII_TXID (or
RXID), Alexandru, what direction does the skew settings apply to?
--
Florian
next prev parent reply other threads:[~2016-11-14 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 23:32 [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed Alexandru Gagniuc
2016-11-14 21:18 ` David Miller
2016-11-14 21:25 ` Florian Fainelli [this message]
2016-11-14 21:54 ` Alex
2016-11-16 3:12 ` David Miller
2016-11-16 9:02 ` [PATCH v2] " Alexandru Gagniuc
2016-11-16 13:50 ` Andrew Lunn
2016-11-16 16:44 ` Alex
2016-11-16 16:54 ` Andrew Lunn
2016-11-16 17:10 ` Alex
2016-11-16 22:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d567c69f-6b57-7083-9090-df01fb140e36@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alex.g@adaptrum.com \
--cc=davem@davemloft.net \
--cc=gokhan@adaptrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).