linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node
Date: Mon, 24 Oct 2022 14:56:17 -0400	[thread overview]
Message-ID: <d5726896-e62b-d19d-454b-700dd1c42222@linaro.org> (raw)
In-Reply-To: <3af48606-731f-6047-92ca-80435f401ae3@linaro.org>

On 24/10/2022 12:48, Dmitry Baryshkov wrote:
> On 24/10/2022 19:46, Krzysztof Kozlowski wrote:
>> On 24/10/2022 12:45, Dmitry Baryshkov wrote:
>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote:
>>>> On 09/12/2021 05:35, Vinod Koul wrote:
>>>>> Add the spmi bus as found in the SM8450 SoC
>>>>>
>>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>>>>> ---
>>>>>    arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++
>>>>>    1 file changed, 18 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> index f75de777f6ea..b80e34fd3fe1 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 {
>>>>>    			interrupt-controller;
>>>>>    		};
>>>>>    
>>>>> +		spmi_bus: spmi@c42d000 {
>>>>> +			compatible = "qcom,spmi-pmic-arb";
>>>>> +			reg = <0x0 0x0c400000 0x0 0x00003000>,
>>>>> +			      <0x0 0x0c500000 0x0 0x00400000>,
>>>>> +			      <0x0 0x0c440000 0x0 0x00080000>,
>>>>> +			      <0x0 0x0c4c0000 0x0 0x00010000>,
>>>>> +			      <0x0 0x0c42d000 0x0 0x00010000>;
>>>>
>>>> This is a patch from December 2021. Is there anything blocking it from
>>>> being merged?
>>>>
>>>> The same applies to several other patches here.
>>>
>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support
>>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT
>>> parts.
>>
>> Why we cannot merge DTS? How is DTS with new nodes depending on any
>> driver changes?
> 
> In this particular case, there was an open question, what should be the 
> bindings for the PMIC ARB v7.

Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait
with this one. I just had an impression that it's about driver changes...

> 
>>
>> Just like I replied to Konrad - if that's true, bindings are simply
>> wrong and should be fixed.
> 
> Maybe I missed the reply. Which email are you referring to?

I meant about this one:

https://lore.kernel.org/linux-arm-msm/8c1428a6-f268-cb03-3e55-887d30236924@linaro.org/T/#m50f4c72775492046f9b0a172e974cab83563af3c

Best regards,
Krzysztof


  reply	other threads:[~2022-10-24 20:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 10:34 [PATCH v2 00/13] arm64: dts: qcom: Add support for SM8450 SoC and QRD board Vinod Koul
2021-12-09 10:34 ` [PATCH v2 01/13] arm64: dts: qcom: Add base SM8450 DTSI Vinod Koul
2021-12-09 10:34 ` [PATCH v2 02/13] arm64: dts: qcom: sm8450: Add tlmm nodes Vinod Koul
2021-12-09 10:34 ` [PATCH v2 03/13] arm64: dts: qcom: sm8450: Add reserved memory nodes Vinod Koul
2021-12-09 10:34 ` [PATCH v2 04/13] arm64: dts: qcom: sm8450: add smmu nodes Vinod Koul
2021-12-09 10:34 ` [PATCH v2 05/13] arm64: dts: qcom: Add base SM8450 QRD DTS Vinod Koul
2021-12-09 23:06   ` kernel test robot
2021-12-10  3:13   ` kernel test robot
2021-12-09 10:34 ` [PATCH v2 06/13] arm64: dts: qcom: sm8450-qrd: Add rpmh regulator nodes Vinod Koul
2021-12-09 10:34 ` [PATCH v2 07/13] arm64: dts: qcom: sm8450: add ufs nodes Vinod Koul
2021-12-09 10:35 ` [PATCH v2 08/13] arm64: dts: qcom: sm8450-qrd: enable " Vinod Koul
2021-12-09 10:35 ` [PATCH v2 09/13] arm64: dts: qcom: sm8450: add interconnect nodes Vinod Koul
2021-12-09 15:46   ` Konrad Dybcio
2021-12-10  9:37   ` Georgi Djakov
2021-12-09 10:35 ` [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node Vinod Koul
2022-10-24 14:56   ` Krzysztof Kozlowski
2022-10-24 15:06     ` konrad.dybcio
2022-10-24 16:16       ` Krzysztof Kozlowski
2022-10-24 16:45     ` Dmitry Baryshkov
2022-10-24 16:46       ` Krzysztof Kozlowski
2022-10-24 16:48         ` Dmitry Baryshkov
2022-10-24 18:56           ` Krzysztof Kozlowski [this message]
2022-10-24 18:58             ` Dmitry Baryshkov
2022-10-26  5:33               ` Vinod Koul
2022-11-17 14:57                 ` Konrad Dybcio
2022-11-18  9:16                   ` Konrad Dybcio
2021-12-09 10:35 ` [PATCH v2 11/13] arm64: dts: qcom: sm8450: Add rpmhpd node Vinod Koul
2021-12-09 10:35 ` [PATCH v2 12/13] arm64: dts: qcom: sm8450: add cpufreq support Vinod Koul
2021-12-09 10:35 ` [PATCH v2 13/13] arm64: dts: qcom: sm8450: add i2c13 and i2c14 device nodes Vinod Koul
2021-12-09 15:47   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5726896-e62b-d19d-454b-700dd1c42222@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).